<font color="#333333"><font size="2"><font face="arial,helvetica,sans-serif">That does not justify the redirect.</font></font></font><div><font color="#333333"><font size="2"><font face="arial,helvetica,sans-serif"><br clear="all">
</font></font></font><div><strong><font face="arial, helvetica, sans-serif">----</font></strong></div><div><font face="arial, helvetica, sans-serif"><strong>Emil Uzelac</strong> | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E: <a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a> | <a href="http://themeid.com/" target="_blank">http://themeid.com</a></font></div>
<div><font color="#999999" face="arial, helvetica, sans-serif">Make everything as simple as possible, but not simpler. - Albert Einstein</font></div><br>
<br><br><div class="gmail_quote">On Wed, May 11, 2011 at 4:51 PM, Jonny Cauvain <span dir="ltr"><<a href="mailto:furcifer@furcifer.me">furcifer@furcifer.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<p>The author of that theme is one of our reviewers. XD and i see no problem with that demo re-direct. But that's just my 2c </p>
<p></p><blockquote type="cite"><div><div></div><div class="h5">On 11 May 2011 22:41, "Tony Jansen" <<a href="mailto:info@tonyjansen.nl" target="_blank">info@tonyjansen.nl</a>> wrote:<br><br><div lang="NL" link="blue" vlink="purple">
<div><p class="MsoNormal">
<span lang="EN-US">Hello all,</span></p><p class="MsoNormal"><span lang="EN-US"> </span></p><p class="MsoNormal"><span lang="EN-US">Earlier today during a review I encountered the following code in functions.php:</span></p>
<p class="MsoNormal"><span lang="EN-US"> /**</span></p><p class="MsoNormal"><span lang="EN-US"> * The WordPress Theme Directory Preview may not be appropriate for this theme, so redirecting to custom preview</span></p><p class="MsoNormal">
<span lang="EN-US"> */</span></p><p class="MsoNormal"><span lang="EN-US">if( false !== strpos( site_url(), '<a href="http://wp-themes.com" target="_blank">http://wp-themes.com</a>' )) {</span></p><p class="MsoNormal">
<span lang="EN-US"> wp_redirect( '<a href="http://demo.onedesigns.com/minimatica/" target="_blank">http://demo.onedesigns.com/minimatica/</a>' );</span></p><p class="MsoNormal"><span lang="EN-US"> exit();</span></p>
<p class="MsoNormal">}</p><p class="MsoNormal"><span lang="EN-US">which circumvents the regular theme preview to display something that may have nothing to do with the theme at all or worse (not the case in this case, mind you).</span></p>
<p class="MsoNormal"><span lang="EN-US">I have halted the review after conferring with greuben, who noted that it was bad and unacceptable, and I recommended a not-approved. </span></p><p class="MsoNormal"><span lang="EN-US">This technique may be old hat but I still like to know what you think about it, was I right to handle it this way?</span></p>
<p class="MsoNormal"><span lang="EN-US"> </span></p><p class="MsoNormal"><a href="http://themes.trac.wordpress.org/ticket/3787#comment:3" target="_blank"><span lang="EN-US">http://themes.trac.wordpress.org/ticket/3787#comment:3</span></a></p>
<p class="MsoNormal"> </p><p class="MsoNormal">Best Regards,</p><p class="MsoNormal">Tony Jansen<span lang="EN-US"></span></p><p class="MsoNormal"><span lang="EN-US"> </span></p></div></div><br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote><p></p>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>