[theme-reviewers] More Review Questions

[Edward Caissie]

Mike -

A few more answers (*grin*) ...

ALmost any Theme Unit Test fail would generally indicate that the Theme has
other issues to be addressed; and, even it is only on major item of the
Theme Unit Test most are easily addressed and can be corrected quickly by
the Theme author. Sometimes suggestions on how to fix the more obvious
issues are also useful and welcomed by the author(s) as well.

There should be, at a minimum, a direct link to the post from the index.php
template. Essentially there should always be a way to reach the single.php
template (if it exists) display of the post no matter the template file
being used.

I don't recall discussing the requirement of a title on archive pages ... I
would consider it good UX but at this time not a requirement; at least not
without a very strong case why a title would need to exist for an archive
page.

Internationalization of a Theme should be managed entirely within the Theme
itself. It is part of the reason a unique textdomain (related to the theme)
is required when implementing i18n. Proper implementation of i18n should
also be addressed but if it is the only issue with a Theme then I would look
at it more as a recommendation to be addressed with the next version
submitted.


Cais.

On Mon, Mar 28, 2011 at 10:16 AM, <michael at mfields.org> wrote:

> Hi,
>
> Have a few more questions:
>
> In regards to posts with no titles. Is the lack of a permalink a deal
> breaker? Actually, is failing any one of the unit tests a reason to fail a
> theme? (I believe that it is, but would like confirmation) The theme I
> reviewed is displaying a comment link, but in cases where a user has
> disabled comments on a particular post (or has set WordPress to do this
> automatically), this would leave the visitor without a direct link to the
> post. Is a comment link enough or does there need to be a dedicated call
> to get_permalink() or the_permalink() in each post?
>
> Are archive pages required to have a title? Category, Tags, Date(s). I
> don't believe that I've read this anywhere, just wondering.
>
> i18n
> Is this code ever acceptable in a theme: __('Name'). I'm pretty sure that
> the following should be done even if the string exists in WordPress, but
> am uncertain to policy: __('Name', 'theme-slug'). Is this subject to fail
> or merely a suggestion?
>
> Thanks!
> -Mike
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110328/cdc3fec7/attachment-0001.htm>