[theme-reviewers] Theme Check on theme uploader

[Edward Caissie]

Has it been a month already?!

I was going to suggest the end of the month so we start on April 1 ... but
some may take that the wrong way (*grin*)

I'm good with the 30 days "grace" period we originally discussed.


Cais.

On Mon, Mar 21, 2011 at 2:48 PM, Amy <sabreuse at gmail.com> wrote:

> Let's do it!
>
> On Mar 21, 2011, at 2:25 PM, Otto <otto at ottodestruct.com> wrote:
>
> > I recently resynched the theme check on the uploader to the latest
> > version of the theme check plugin, to add the 3.1 checks to the
> > uploader too.
> >
> > At one time, we discussed making the theme check there require a
> > mandatory pass for allowing the theme to be uploaded at all. The
> > timeline suggested for this was one month after the release of 3.1. We
> > are now at that point in time, and so unless there is a good reason
> > not to do so, I plan on making that change this week.
> >
> > What this means:
> >
> > Right now, the uploader does print out the results of the theme check,
> > along with the computed "pass" or "fail". There are currently only a
> > few conditions that will cause the uploader to abort and not submit
> > the theme. The more wide-ranging theme check has been purely advisory
> > until now, it does not affect the ability to upload the theme.
> >
> > This change would make any "fail" condition from the theme uploader
> > abort in the same manner, and stop the theme from being uploaded.
> > Getting a "pass" on the theme check would be a requirement.
> >
> > The result of this would be to reduce the number of submissions in
> > trac, and reduce the need of the reviewers to run theme check
> > themselves, as a pass would be assured for it to even make it that
> > far.
> >
> > Note that not all messages produced by theme check produce a fail. The
> > "recommended" and "info" items, for example, are merely informational,
> > they don't affect the pass/fail case. Only the warnings and requireds
> > and such cause a theme to fail the check.
> >
> > If anybody has any objections or suggestions or even just thoughts,
> > now's the time to talk about them.
> >
> > -Otto
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110321/0c6d4ebb/attachment.htm>