[theme-reviewers] Theme quality review process

[Chip Bennett]

I generally try, at a minimum, to test each Theme Option discretely, to
ensure that the setting can be changed, and that the Theme functionality or
output changes accordingly, with no errors. Theme Reviewers should ensure
due diligence when testing Theme options, but it is not always feasible to
test every option, or every permutation of options, in order to flush out
any potential bugs or issues.

Things can - and do - get missed. The most helpful things to do, when such
things are discovered:

1) File a bug report with the Theme Developer (or start a topic in the
Theme's WPORG support forum)
2) Make a note on the most recent Trac ticket, indicating what was found

Regarding W3C validation: it is a very high-level challenge. I test against
the Readability Test Post, to try to ensure as few WordPress core-produced
issues as possible (no Gallery shortcode, no comments, likely no search
form, etc.). We're looking for major issues, not 100% perfect validation.

Chip

On Wed, Jun 8, 2011 at 1:49 PM, Darren Slatten <darrenslatten at gmail.com>wrote:

> I could be wrong, but I got the feeling that part of the question was along
> the lines of:
>
> *If PHP notices are not permitted, then why do some already-accepted
> themes generate PHP notices?*
>
> One possibility is that a particular theme might offer a wide range of
> different options/configurations--and only some combinations generate PHP
> notices. This brings up a good question, which is:
>
> *To what extent do/should theme reviewers check for PHP notices (or other
> errors) that only occur when certain theme options are enabled?*
>
> This issue extends to W3C validation as well, since most theme options
> change the HTML output in one way or another. For themes that have a large
> (possibly infinite) set of configurations, how would someone really know if
> the theme is capable of producing errors?
>
> -Darren
>
>
>
>
> On Wed, Jun 8, 2011 at 12:47 PM, Otto <otto at ottodestruct.com> wrote:
>
>> On Wed, Jun 8, 2011 at 12:39 PM, Azizur Rahman
>> <prodevstudio+wordpress at gmail.com> wrote:
>> > Question is should this kind of php notices be OK-ed?
>>
>> First item in the Theme Review Guidelines:
>> http://codex.wordpress.org/Theme_Review
>>
>> "Code Quality: Themes are required not to generate any WordPress
>> deprecated-function notices, PHP errors, warnings, or notices,
>> HTML/CSS validation errors, or JavaScript errors."
>>
>> So, no.
>>
>> Note: "Validation errors" is subjective. The W3C validators ain't
>> always right. So use your judgement there. But PHP notices are pretty
>> cut and dry.
>>
>> -Otto
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110608/78ebd8ce/attachment-0001.htm>