<div>I generally try, at a minimum, to test each Theme Option discretely, to ensure that the setting can be changed, and that the Theme functionality or output changes accordingly, with no errors. Theme Reviewers should ensure due diligence when testing Theme options, but it is not always feasible to test every option, or every permutation of options, in order to flush out any potential bugs or issues.</div>
<div><br></div><div>Things can - and do - get missed. The most helpful things to do, when such things are discovered:<div><br></div><div>1) File a bug report with the Theme Developer (or start a topic in the Theme's WPORG support forum)</div>
<div>2) Make a note on the most recent Trac ticket, indicating what was found</div><div><br></div><div>Regarding W3C validation: it is a very high-level challenge. I test against the Readability Test Post, to try to ensure as few WordPress core-produced issues as possible (no Gallery shortcode, no comments, likely no search form, etc.). We're looking for major issues, not 100% perfect validation.</div>
<div><br></div><div>Chip</div><br><div class="gmail_quote">On Wed, Jun 8, 2011 at 1:49 PM, Darren Slatten <span dir="ltr"><<a href="mailto:darrenslatten@gmail.com">darrenslatten@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I could be wrong, but I got the feeling that part of the question was along the lines of:<br><br><i>If PHP notices are not permitted, then why do some already-accepted themes generate PHP notices?</i><br><br>One possibility is that a particular theme might offer a wide range of different options/configurations--and only some combinations generate PHP notices. This brings up a good question, which is:<br>
<br><i>To what extent do/should theme reviewers check for PHP notices (or other errors) that only occur when certain theme options are enabled?</i><br><br>This issue extends to W3C validation as well, since most theme options change the HTML output in one way or another. For themes that have a large (possibly infinite) set of configurations, how would someone really know if the theme is capable of producing errors?<br>
<font color="#888888">
<br>-Darren</font><div><div></div><div class="h5"><br><br><br><br><div class="gmail_quote">On Wed, Jun 8, 2011 at 12:47 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On Wed, Jun 8, 2011 at 12:39 PM, Azizur Rahman<br>
<<a href="mailto:prodevstudio%2Bwordpress@gmail.com" target="_blank">prodevstudio+wordpress@gmail.com</a>> wrote:<br>
> Question is should this kind of php notices be OK-ed?<br>
<br>
</div>First item in the Theme Review Guidelines:<br>
<a href="http://codex.wordpress.org/Theme_Review" target="_blank">http://codex.wordpress.org/Theme_Review</a><br>
<br>
"Code Quality: Themes are required not to generate any WordPress<br>
deprecated-function notices, PHP errors, warnings, or notices,<br>
HTML/CSS validation errors, or JavaScript errors."<br>
<br>
So, no.<br>
<br>
Note: "Validation errors" is subjective. The W3C validators ain't<br>
always right. So use your judgement there. But PHP notices are pretty<br>
cut and dry.<br>
<font color="#888888"><br>
-Otto<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</font></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>