[theme-reviewers] Second Opinion

Chip Bennett chip at chipbennett.net
Wed Jan 19 17:29:27 UTC 2011 

No worries. I'm not immune to faulty reviews (eh, Phil? ;) ). This one
probably makes a good case study for handling of derivative Themes.

Chip

On Wed, Jan 19, 2011 at 11:24 AM, Emil Uzelac <emil at themeid.com> wrote:

> I wasn't aware that it was you :(
> Yeah, there's no difference in line code at all. This is indeed TwentyTen.
>
>
> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac<http://twitter.com/emiluzelac>| E:
> emil at themeid.com | http://themeid.com
> *Make everything as simple as possible, but not simpler.* - Albert
> Einstein
>
>
>
> On Wed, Jan 19, 2011 at 11:21 AM, Chip Bennett <chip at chipbennett.net>wrote:
>
>> That one was one I reviewed/approved; *mea culpa*.
>>
>> Looks like I didn't do a full review on that one. (Looks like it was from
>> about two months ago. Since then, I've started looking more carefully at
>> textdomain, and substantial differences for TwentyTen-derived Themes.)
>>
>> Chalk it up to a bad review: Bad Chip! :)
>>
>> I'd be fine with suspending, and asking for a revision, to address
>> deficiencies.
>>
>> Chip
>>
>>
>> On Wed, Jan 19, 2011 at 11:16 AM, Emil Uzelac <emil at themeid.com> wrote:
>>
>>> Let's drop the link building for a moment and look into the same author
>>> shall we?
>>> All right this http://wordpress.org/extend/themes/all-green is approved
>>> and the entire code is from TwentyTen, every single like, it even says
>>> TwentyTen directly in files. How can that be?
>>>
>>>
>>>
>>> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac<http://twitter.com/emiluzelac>| E:
>>> emil at themeid.com | http://themeid.com
>>> *Make everything as simple as possible, but not simpler.* - Albert
>>> Einstein
>>>
>>>
>>>
>>>   On Wed, Jan 19, 2011 at 10:16 AM, Chip Bennett <chip at chipbennett.net>wrote:
>>>
>>>> The standard is "*significantly different design and/or functionality*".
>>>> Granted, it's entirely subjective, but we *are* taking into consideration.
>>>>
>>>> I don't know how to draw the line any more clearly than that, when the
>>>> reality is that a non-trivial number of submitted Themes will *always* be
>>>> derived from the WordPress default Theme - which right now is TwentyTen.
>>>>
>>>> Thus, it is rather infeasible to disallow *any* TwentyTen-derived
>>>> Themes.
>>>>
>>>> Chip
>>>>
>>>>
>>>> On Wed, Jan 19, 2011 at 10:11 AM, Otto <otto at ottodestruct.com> wrote:
>>>>
>>>>> Are we actually allowing basic modifications to the twentyten theme to
>>>>> go into the directory?
>>>>>
>>>>> Can't we say that themes must be at least somewhat *original*? Simply
>>>>> replacing the
>>>>> artwork and screwing around with the CSS of an existing theme does not
>>>>> a new theme create.
>>>>>
>>>>> Just a thought.
>>>>>
>>>>> -Otto
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Jan 19, 2011 at 9:04 AM, Daniel Tara <contact at onedesigns.com>
>>>>> wrote:
>>>>> > Twenty Ten has that hook and that theme copies plenty of code from
>>>>> it. I
>>>>> > think it’s residual waste from wannabe coders that don’t actually
>>>>> understand
>>>>> > what they’re doing.
>>>>> >
>>>>> >
>>>>> >
>>>>> > Daniel
>>>>> >
>>>>> >
>>>>> >
>>>>> > From: theme-reviewers-bounces at lists.wordpress.org
>>>>> > [mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of
>>>>> Philip M.
>>>>> > Hofer (Frumph)
>>>>> > Sent: Wednesday, January 19, 2011 4:43 PM
>>>>> >
>>>>> > To: theme-reviewers at lists.wordpress.org
>>>>> > Subject: Re: [theme-reviewers] Second Opinion
>>>>> >
>>>>> >
>>>>> >
>>>>> > I'm thinking there's some plugin out there that's doing it, since
>>>>> plugin's
>>>>> > are not .. moderated, they can do anything of the like.
>>>>> >
>>>>> >
>>>>> >
>>>>> > ----- Original Message -----
>>>>> >
>>>>> > From: Chip Bennett
>>>>> >
>>>>> > To: theme-reviewers at lists.wordpress.org
>>>>> >
>>>>> > Sent: Wednesday, January 19, 2011 6:39 AM
>>>>> >
>>>>> > Subject: Re: [theme-reviewers] Second Opinion
>>>>> >
>>>>> >
>>>>> >
>>>>> > I've seen quite a few Themes that have such a "do_action(
>>>>> 'my_theme_credits'
>>>>> > )" in footer.php, but without a corresponding add_action() hook in
>>>>> > functions.php.
>>>>> >
>>>>> >
>>>>> >
>>>>> > I've always taken it to be sloppiness in copying from another Theme,
>>>>> adding
>>>>> > in a hook but not knowing to define it. Is it something else?
>>>>> >
>>>>> >
>>>>> >
>>>>> > Chip
>>>>> >
>>>>> > On Wed, Jan 19, 2011 at 8:25 AM, Philip M. Hofer (Frumph)
>>>>> > <philip at frumph.net> wrote:
>>>>> >
>>>>> > .. is there an action that hooks into it in the theme or is he
>>>>> hooking in
>>>>> > someplace else like a plugin?
>>>>> >
>>>>> >
>>>>> >
>>>>> > <?php do_action( 'all_green_credits' ); ?>
>>>>> >
>>>>> > ----- Original Message -----
>>>>> >
>>>>> > From: Daniel Tara
>>>>> >
>>>>> > To: theme-reviewers at lists.wordpress.org
>>>>> >
>>>>> > Sent: Wednesday, January 19, 2011 5:55 AM
>>>>> >
>>>>> > Subject: Re: [theme-reviewers] Second Opinion
>>>>> >
>>>>> >
>>>>> >
>>>>> > If you don’t mean that he is building links via the
>>>>> 'all_green_credits'
>>>>> > hook, then I don’t get it either.
>>>>> >
>>>>> > Anyway, there’s no function hooked to that action in any theme file.
>>>>> >
>>>>> >
>>>>> >
>>>>> > Daniel
>>>>> >
>>>>> >
>>>>> >
>>>>> > From: theme-reviewers-bounces at lists.wordpress.org
>>>>> > [mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of
>>>>> Chip
>>>>> > Bennett
>>>>> > Sent: Wednesday, January 19, 2011 3:40 PM
>>>>> > To: theme-reviewers at lists.wordpress.org
>>>>> > Subject: Re: [theme-reviewers] Second Opinion
>>>>> >
>>>>> >
>>>>> >
>>>>> > So for the not-enough-sleep-and-no-coffee-yet version: what am I
>>>>> looking at,
>>>>> > in the footer.php that you linked? :)
>>>>> >
>>>>> >
>>>>> >
>>>>> > Chip
>>>>> >
>>>>> > On Wed, Jan 19, 2011 at 4:52 AM, Emil Uzelac <emil at themeid.com>
>>>>> wrote:
>>>>> >
>>>>> > This would be no go, the guy is building links via theme and that's
>>>>> not
>>>>> > cool. Please see Google cache on this http://is.gd/TSWfvV
>>>>> >
>>>>> >
>>>>> >
>>>>> > Emil Uzelac | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
>>>>> > emil at themeid.com | http://themeid.com
>>>>> >
>>>>> > Make everything as simple as possible, but not simpler. - Albert
>>>>> Einstein
>>>>> >
>>>>> >
>>>>> >
>>>>> > On Tue, Jan 18, 2011 at 11:13 AM, Philip M. Hofer (Frumph)
>>>>> > <philip at frumph.net> wrote:
>>>>> >
>>>>> > heh well thats not far from what it looks like in firefox too, that
>>>>> text on
>>>>> > the image looks horrible
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> > ----- Original Message -----
>>>>> >
>>>>> > From: Chip Bennett
>>>>> >
>>>>> > To: theme-reviewers at lists.wordpress.org
>>>>> >
>>>>> > Sent: Tuesday, January 18, 2011 8:55 AM
>>>>> >
>>>>> > Subject: Re: [theme-reviewers] Second Opinion
>>>>> >
>>>>> >
>>>>> >
>>>>> > Follow up:
>>>>> >
>>>>> >
>>>>> >
>>>>> > Firefox: renders fine
>>>>> >
>>>>> > Chrome: does not render properly
>>>>> >
>>>>> > IE8: does not render properly
>>>>> >
>>>>> >
>>>>> >
>>>>> > By "does not render properly", here's what I'm seeing.
>>>>> >
>>>>> >
>>>>> >
>>>>> > Chip
>>>>> >
>>>>> >
>>>>> >
>>>>> > On Tue, Jan 18, 2011 at 10:37 AM, Philip M. Hofer (Frumph)
>>>>> > <philip at frumph.net> wrote:
>>>>> >
>>>>> > i'm sorry, i'm confused as to why it's not rendering to you?
>>>>> >
>>>>> >
>>>>> >
>>>>> > think its a browser issue or connection to the site?
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> > ----- Original Message -----
>>>>> >
>>>>> > From: Chip Bennett
>>>>> >
>>>>> > To: theme-reviewers at lists.wordpress.org
>>>>> >
>>>>> > Sent: Tuesday, January 18, 2011 8:05 AM
>>>>> >
>>>>> > Subject: Re: [theme-reviewers] Second Opinion
>>>>> >
>>>>> >
>>>>> >
>>>>> > Can you and Phil post screencaps on the ticket? I'll reinstall the
>>>>> Theme and
>>>>> > do the same.
>>>>> >
>>>>> >
>>>>> >
>>>>> > (Or, if it's not the author's original work, maybe we just deny it on
>>>>> those
>>>>> > grounds?)
>>>>> >
>>>>> >
>>>>> >
>>>>> > Chip
>>>>> >
>>>>> > On Tue, Jan 18, 2011 at 10:02 AM, Edward Caissie <
>>>>> edward.caissie at gmail.com>
>>>>> > wrote:
>>>>> >
>>>>> > IT rendered fine but like Phil pointed out, there are some obvious
>>>>> items to
>>>>> > look at ...
>>>>> >
>>>>> >
>>>>> >
>>>>> > On Tue, Jan 18, 2011 at 11:00 AM, Philip M. Hofer (Frumph)
>>>>> > <philip at frumph.net> wrote:
>>>>> >
>>>>> > yes yes and yes, renders fine sorta..
>>>>> >
>>>>> >
>>>>> >
>>>>> > last post from from last october, the 404 page renders like crap
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> > The real template author for this is http://www.bloggerthemes.net/
>>>>> >
>>>>> >
>>>>> >
>>>>> > as shown here
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> http://www.dhetemplate.com/2010/11/free-all-green-blogger-template.html#
>>>>> >
>>>>> >
>>>>> >
>>>>> > (notice the paydaydesigns.info on that page)
>>>>> >
>>>>> >
>>>>> >
>>>>> > ----- Original Message -----
>>>>> >
>>>>> > From: Chip Bennett
>>>>> >
>>>>> > To: theme-reviewers at lists.wordpress.org
>>>>> >
>>>>> > Sent: Tuesday, January 18, 2011 7:47 AM
>>>>> >
>>>>> > Subject: Re: [theme-reviewers] Second Opinion
>>>>> >
>>>>> >
>>>>> >
>>>>> > Can you read any of the content?
>>>>> >
>>>>> > Does it look like screenshot.png?
>>>>> >
>>>>> > On Tue, Jan 18, 2011 at 9:42 AM, Edward Caissie <
>>>>> edward.caissie at gmail.com>
>>>>> > wrote:
>>>>> >
>>>>> > IT seems to load fine for me ... haven't tested it or anything. What
>>>>> issues
>>>>> > are you having?
>>>>> >
>>>>> >
>>>>> >
>>>>> > On Tue, Jan 18, 2011 at 10:40 AM, Jay <furcifer at furcifer.me> wrote:
>>>>> >
>>>>> > Hey chip.
>>>>> >
>>>>> > Just taking a quick look from my phone, it's the same theme that's on
>>>>> the
>>>>> > author url, and i'm having issues with that.
>>>>> >
>>>>> > Chip Bennett <chip at chipbennett.net> wrote:
>>>>> >
>>>>> >>Hey All,
>>>>> >>
>>>>> >>I could not get this Theme
>>>>> >
>>>>> >><https://themes.trac.wordpress.org/ticket/2655>to render properly
>>>>> for
>>>>> >
>>>>> >>me. Can someone else confirm that it is the Theme,
>>>>> >>and not something with my test environment?
>>>>> >>
>>>>> >>Thanks!
>>>>> >>
>>>>> >>Chip
>>>>> >>
>>>>> >
>>>>> >>_______________________________________________
>>>>> >>theme-reviewers mailing list
>>>>> >>theme-reviewers at lists.wordpress.org
>>>>> >>http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> >
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> >
>>>>> >
>>>>> > ________________________________
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> >
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> >
>>>>> >
>>>>> > ________________________________
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> >
>>>>> >
>>>>> > ________________________________
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> >
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> >
>>>>> >
>>>>> > ________________________________
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> >
>>>>> >
>>>>> > ________________________________
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> > _______________________________________________
>>>>> > theme-reviewers mailing list
>>>>> > theme-reviewers at lists.wordpress.org
>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>> >
>>>>> >
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110119/039b5414/attachment-0001.htm>

More information about the theme-reviewers mailing list