No worries. I'm not immune to faulty reviews (eh, Phil? ;) ). This one probably makes a good case study for handling of derivative Themes.<div><br></div><div>Chip<br><br><div class="gmail_quote">On Wed, Jan 19, 2011 at 11:24 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com">emil@themeid.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div>I wasn't aware that it was you :( </div>
<div>Yeah, there's no difference in line code at all. This is indeed TwentyTen.</div><div class="im">
<div><br clear="all"> </div>
<div><font size="1"><strong>Emil Uzelac</strong> | ThemeID | T: 224-444-0006 | Twitter: <a href="http://twitter.com/emiluzelac" target="_blank">@EmilUzelac</a> | E: </font><a href="mailto:emil@themeid.com" target="_blank"><font size="1">emil@themeid.com</font></a><font size="1"> | </font><a href="http://themeid.com/" target="_blank"><font size="1">http://themeid.com</font></a></div>
<div><font size="1"><font color="#666666"><em>Make everything as simple as possible, but not simpler.</em> - Albert Einstein</font></font></div><br><br><br>
</div><div><div></div><div class="h5"><div class="gmail_quote">On Wed, Jan 19, 2011 at 11:21 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote style="border-left:#ccc 1px solid;margin:0px 0px 0px 0.8ex;padding-left:1ex" class="gmail_quote">That one was one I reviewed/approved; <i>mea culpa</i>.
<div><br></div>
<div>Looks like I didn't do a full review on that one. (Looks like it was from about two months ago. Since then, I've started looking more carefully at textdomain, and substantial differences for TwentyTen-derived Themes.)</div>
<div><br></div>
<div>Chalk it up to a bad review: Bad Chip! :)</div>
<div><br></div>
<div>I'd be fine with suspending, and asking for a revision, to address deficiencies.</div>
<div><br></div>
<div><font color="#888888">Chip</font>
<div>
<div></div>
<div><br><br>
<div class="gmail_quote">On Wed, Jan 19, 2011 at 11:16 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span> wrote:<br>
<blockquote style="border-left:#ccc 1px solid;margin:0px 0px 0px 0.8ex;padding-left:1ex" class="gmail_quote">
<div>Let's drop the link building for a moment and look into the same author shall we?</div>
<div>All right this <a href="http://wordpress.org/extend/themes/all-green" target="_blank">http://wordpress.org/extend/themes/all-green</a> is approved and the entire code is from TwentyTen, every single like, it even says TwentyTen directly in files. How can that be?</div>
<div>
<div> </div>
<div><br clear="all"> </div>
<div><font size="1"><strong>Emil Uzelac</strong> | ThemeID | T: 224-444-0006 | Twitter: <a href="http://twitter.com/emiluzelac" target="_blank">@EmilUzelac</a> | E: </font><a href="mailto:emil@themeid.com" target="_blank"><font size="1">emil@themeid.com</font></a><font size="1"> | </font><a href="http://themeid.com/" target="_blank"><font size="1">http://themeid.com</font></a></div>
<div><font size="1"><font color="#666666"><em>Make everything as simple as possible, but not simpler.</em> - Albert Einstein</font></font></div><br><br><br></div>
<div>
<div></div>
<div>
<div class="gmail_quote">On Wed, Jan 19, 2011 at 10:16 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote style="border-left:#ccc 1px solid;margin:0px 0px 0px 0.8ex;padding-left:1ex" class="gmail_quote">The standard is "<b>significantly different design and/or functionality</b>". Granted, it's entirely subjective, but we *are* taking into consideration.
<div><br></div>
<div>I don't know how to draw the line any more clearly than that, when the reality is that a non-trivial number of submitted Themes will *always* be derived from the WordPress default Theme - which right now is TwentyTen.</div>
<div><br></div>
<div>Thus, it is rather infeasible to disallow *any* TwentyTen-derived Themes.</div>
<div><br></div>
<div><font color="#888888">Chip</font>
<div>
<div></div>
<div><br><br>
<div class="gmail_quote">On Wed, Jan 19, 2011 at 10:11 AM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br>
<blockquote style="border-left:#ccc 1px solid;margin:0px 0px 0px 0.8ex;padding-left:1ex" class="gmail_quote">Are we actually allowing basic modifications to the twentyten theme to<br>go into the directory?<br><br>Can't we say that themes must be at least somewhat *original*? Simply<br>
replacing the<br>artwork and screwing around with the CSS of an existing theme does not<br>a new theme create.<br><br>Just a thought.<br><font color="#888888"><br>-Otto<br></font>
<div>
<div></div>
<div><br><br><br>On Wed, Jan 19, 2011 at 9:04 AM, Daniel Tara <<a href="mailto:contact@onedesigns.com" target="_blank">contact@onedesigns.com</a>> wrote:<br>> Twenty Ten has that hook and that theme copies plenty of code from it. I<br>
> think it’s residual waste from wannabe coders that don’t actually understand<br>> what they’re doing.<br>><br>><br>><br>> Daniel<br>><br>><br>><br>> From: <a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a><br>
> [mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>] On Behalf Of Philip M.<br>> Hofer (Frumph)<br>> Sent: Wednesday, January 19, 2011 4:43 PM<br>
><br>> To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> Subject: Re: [theme-reviewers] Second Opinion<br>><br>><br>><br>> I'm thinking there's some plugin out there that's doing it, since plugin's<br>
> are not .. moderated, they can do anything of the like.<br>><br>><br>><br>> ----- Original Message -----<br>><br>> From: Chip Bennett<br>><br>> To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
><br>> Sent: Wednesday, January 19, 2011 6:39 AM<br>><br>> Subject: Re: [theme-reviewers] Second Opinion<br>><br>><br>><br>> I've seen quite a few Themes that have such a "do_action( 'my_theme_credits'<br>
> )" in footer.php, but without a corresponding add_action() hook in<br>> functions.php.<br>><br>><br>><br>> I've always taken it to be sloppiness in copying from another Theme, adding<br>> in a hook but not knowing to define it. Is it something else?<br>
><br>><br>><br>> Chip<br>><br>> On Wed, Jan 19, 2011 at 8:25 AM, Philip M. Hofer (Frumph)<br>> <<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>> wrote:<br>><br>> .. is there an action that hooks into it in the theme or is he hooking in<br>
> someplace else like a plugin?<br>><br>><br>><br>> <?php do_action( 'all_green_credits' ); ?><br>><br>> ----- Original Message -----<br>><br>> From: Daniel Tara<br>><br>> To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
><br>> Sent: Wednesday, January 19, 2011 5:55 AM<br>><br>> Subject: Re: [theme-reviewers] Second Opinion<br>><br>><br>><br>> If you don’t mean that he is building links via the 'all_green_credits'<br>
> hook, then I don’t get it either.<br>><br>> Anyway, there’s no function hooked to that action in any theme file.<br>><br>><br>><br>> Daniel<br>><br>><br>><br>> From: <a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a><br>
> [mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>] On Behalf Of Chip<br>> Bennett<br>> Sent: Wednesday, January 19, 2011 3:40 PM<br>
> To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> Subject: Re: [theme-reviewers] Second Opinion<br>><br>><br>><br>> So for the not-enough-sleep-and-no-coffee-yet version: what am I looking at,<br>
> in the footer.php that you linked? :)<br>><br>><br>><br>> Chip<br>><br>> On Wed, Jan 19, 2011 at 4:52 AM, Emil Uzelac <<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>> wrote:<br>
><br>> This would be no go, the guy is building links via theme and that's not<br>> cool. Please see Google cache on this <a href="http://is.gd/TSWfvV" target="_blank">http://is.gd/TSWfvV</a><br>><br>><br>
><br>> Emil Uzelac | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:<br>> <a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a> | <a href="http://themeid.com/" target="_blank">http://themeid.com</a><br>
><br>> Make everything as simple as possible, but not simpler. - Albert Einstein<br>><br>><br>><br>> On Tue, Jan 18, 2011 at 11:13 AM, Philip M. Hofer (Frumph)<br>> <<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>> wrote:<br>
><br>> heh well thats not far from what it looks like in firefox too, that text on<br>> the image looks horrible<br>><br>><br>><br>><br>><br>> ----- Original Message -----<br>><br>> From: Chip Bennett<br>
><br>> To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>><br>> Sent: Tuesday, January 18, 2011 8:55 AM<br>><br>> Subject: Re: [theme-reviewers] Second Opinion<br>
><br>><br>><br>> Follow up:<br>><br>><br>><br>> Firefox: renders fine<br>><br>> Chrome: does not render properly<br>><br>> IE8: does not render properly<br>><br>><br>><br>> By "does not render properly", here's what I'm seeing.<br>
><br>><br>><br>> Chip<br>><br>><br>><br>> On Tue, Jan 18, 2011 at 10:37 AM, Philip M. Hofer (Frumph)<br>> <<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>> wrote:<br>
><br>> i'm sorry, i'm confused as to why it's not rendering to you?<br>><br>><br>><br>> think its a browser issue or connection to the site?<br>><br>><br>><br>><br>><br>> ----- Original Message -----<br>
><br>> From: Chip Bennett<br>><br>> To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>><br>> Sent: Tuesday, January 18, 2011 8:05 AM<br>
><br>
> Subject: Re: [theme-reviewers] Second Opinion<br>><br>><br>><br>> Can you and Phil post screencaps on the ticket? I'll reinstall the Theme and<br>> do the same.<br>><br>><br>><br>> (Or, if it's not the author's original work, maybe we just deny it on those<br>
> grounds?)<br>><br>><br>><br>> Chip<br>><br>> On Tue, Jan 18, 2011 at 10:02 AM, Edward Caissie <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>><br>> wrote:<br>
><br>> IT rendered fine but like Phil pointed out, there are some obvious items to<br>> look at ...<br>><br>><br>><br>> On Tue, Jan 18, 2011 at 11:00 AM, Philip M. Hofer (Frumph)<br>> <<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>> wrote:<br>
><br>> yes yes and yes, renders fine sorta..<br>><br>><br>><br>> last post from from last october, the 404 page renders like crap<br>><br>><br>><br>><br>><br>> The real template author for this is <a href="http://www.bloggerthemes.net/" target="_blank">http://www.bloggerthemes.net/</a><br>
><br>><br>><br>> as shown here<br>><br>><br>><br>> <a href="http://www.dhetemplate.com/2010/11/free-all-green-blogger-template.html#" target="_blank">http://www.dhetemplate.com/2010/11/free-all-green-blogger-template.html#</a><br>
><br>><br>><br>> (notice the <a href="http://paydaydesigns.info/" target="_blank">paydaydesigns.info</a> on that page)<br>><br>><br>><br>> ----- Original Message -----<br>><br>> From: Chip Bennett<br>
><br>> To: <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>><br>> Sent: Tuesday, January 18, 2011 7:47 AM<br>><br>> Subject: Re: [theme-reviewers] Second Opinion<br>
><br>><br>><br>> Can you read any of the content?<br>><br>> Does it look like screenshot.png?<br>><br>> On Tue, Jan 18, 2011 at 9:42 AM, Edward Caissie <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>><br>
> wrote:<br>><br>> IT seems to load fine for me ... haven't tested it or anything. What issues<br>> are you having?<br>><br>><br>><br>> On Tue, Jan 18, 2011 at 10:40 AM, Jay <<a href="mailto:furcifer@furcifer.me" target="_blank">furcifer@furcifer.me</a>> wrote:<br>
><br>> Hey chip.<br>><br>> Just taking a quick look from my phone, it's the same theme that's on the<br>> author url, and i'm having issues with that.<br>><br>> Chip Bennett <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>> wrote:<br>
><br>>>Hey All,<br>>><br>>>I could not get this Theme<br>><br>>><<a href="https://themes.trac.wordpress.org/ticket/2655" target="_blank">https://themes.trac.wordpress.org/ticket/2655</a>>to render properly for<br>
><br>>>me. Can someone else confirm that it is the Theme,<br>>>and not something with my test environment?<br>>><br>>>Thanks!<br>>><br>>>Chip<br>>><br>><br>>>_______________________________________________<br>
>>theme-reviewers mailing list<br>>><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>><br>><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>><br>><br>><br>> ________________________________<br>
><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>><br>><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>><br>><br>><br>> ________________________________<br>
><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>><br>><br>> ________________________________<br>><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>><br>> _______________________________________________<br>
> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>><br>><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>><br>><br>><br>> ________________________________<br>
><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>><br>><br>> ________________________________<br>><br>> _______________________________________________<br>> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>><br>> _______________________________________________<br>
> theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div></div></div><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br><br></blockquote></div><br></div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div><br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br><br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>