[theme-reviewers] Can't assign tickets

Sat Jan 1 19:39:32 UTC 2011

http://themes.trac.wordpress.org/ticket/2274

http://themes.trac.wordpress.org/ticket/2281

http://themes.trac.wordpress.org/ticket/2287

Here you go.

  ----- Original Message ----- 
  From: Daniel Tara 
  To: theme-reviewers at lists.wordpress.org 
  Sent: Saturday, January 01, 2011 11:34 AM
  Subject: Re: [theme-reviewers] Can't assign tickets

  Hi,

  Thanks for the feedback.

  The comments section uses a callback function, that's where tables are used and there are some more sections.

  Sure, send me some more J

  Daniel

  From: theme-reviewers-bounces at lists.wordpress.org [mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Philip M. Hofer (Frumph)
  Sent: Saturday, January 01, 2011 9:26 PM
  To: theme-reviewers at lists.wordpress.org
  Subject: Re: [theme-reviewers] Can't assign tickets

  A couple notes on the Code Check portion 

  JQuery should not be bundled with a theme, should use the bundled with wordpress one.

  XHTML markup is not a => requirement although Chip would beg to differ, but as I agree with Otto there's just so much out there right now that isnt compliant, shouldnt be a requirement for themes, as long as the output looks good, alls good

  the wp_footer(); not directly above the <html> isn't a requirement anymore - i wonder if cais or chip fixed the wording in the documentation yet .. but apparently it's okay to put that within styling divs and such ;/ 

  comments should be using the comment_form() now, which isn't table based so if it's outputting as a table then that needs to be checked, check the comments.php file

  Theme check area:

  wide image doesn't need to be resized it just needs not to flow into any other content areas, as in overflow: hidden; sort of thing  (need doc check on that cais

  Those are my opinions on it, would you like me to assign you some more?

  - Phil

    ----- Original Message ----- 

    From: Daniel Tara 

    To: theme-reviewers at lists.wordpress.org 

    Sent: Saturday, January 01, 2011 11:15 AM

    Subject: Re: [theme-reviewers] Can't assign tickets

    Hi,

    Here is my review of this theme:

    http://themes.trac.wordpress.org/ticket/2252#comment:2

    Daniel

    From: theme-reviewers-bounces at lists.wordpress.org [mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Philip M. Hofer (Frumph)
    Sent: Saturday, January 01, 2011 7:42 PM
    To: theme-reviewers at lists.wordpress.org
    Subject: Re: [theme-reviewers] Can't assign tickets

    I've assigned this ticket to you Daniel 

    http://themes.trac.wordpress.org/ticket/2252

    Give it a go and i'll look at it when you're done, if all's good i'll assign you a few more after that;  if those are good Cais or Pross will give you full reviewer access

      ----- Original Message ----- 

      From: Daniel Tara 

      To: theme-reviewers at lists.wordpress.org 

      Sent: Saturday, January 01, 2011 9:25 AM

      Subject: Re: [theme-reviewers] Can't assign tickets

      So here's what I currently have:

      WordPress 3.0.4 with define('WP_DEBUG', true) and test data 2010-08-02 installed

      Debogger version 0.7.1

      Log Deprecated Notices version 0.1-RC3

      Theme Check version 20101228.1

      From: theme-reviewers-bounces at lists.wordpress.org [mailto:theme-reviewers-bounces at lists.wordpress.org] On Behalf Of Edward Caissie
      Sent: Saturday, January 01, 2011 7:17 PM
      To: theme-reviewers at lists.wordpress.org
      Subject: Re: [theme-reviewers] Can't assign tickets

      Don't forget to install the latest version of the "Log Deprecated Notices" plugin (the dev version), too.

      http://wordpress.org/extend/plugins/log-deprecated-notices/

      Cais

      On Sat, Jan 1, 2011 at 12:14 PM, Daniel Tara <contact at onedesigns.com> wrote:

      Hi Philip,

      My trac username is pseudoxiah.

      And yes, I do have everything set up and am familiar with the theme review
      process.

      Thank you,
      Daniel

       ----- Original Message -----
      From: "Philip M. Hofer \(Frumph\)" <philip at frumph.net>
      Subject: Re: [theme-reviewers] Can't assign tickets
      To: <theme-reviewers at lists.wordpress.org>

      Message-ID: <1273223D12F546B99EC05EEB5C786C1B at frumph.net>
      Content-Type: text/plain; charset="iso-8859-1"

      Hi Daniel, what is your login name for theme trac, I can assign you one for
      you to test out.

      I'm assuming you have the theme-check plugin a site to test with and have
      viewed some of the previous tickets so you can get an idea of how the review
      process goes?  Including reading the Theme_Review codex

      - Phil
       ----- Original Message -----
       From: Daniel Tara
       To: theme-reviewers at lists.wordpress.org
       Sent: Saturday, January 01, 2011 8:17 AM
       Subject: [theme-reviewers] Can't assign tickets

       Hi Guys,

       I just joined the email list to become a theme reviewer. When trying to
      assign the last theme, I only see an option to "leave as new". Am I doing
      something wrong?

       Thanks and Happy New Year,

       Daniel

      ----------------------------------------------------------------------------
      --

       _______________________________________________
       theme-reviewers mailing list
       theme-reviewers at lists.wordpress.org
       http://lists.wordpress.org/mailman/listinfo/theme-reviewers

      -------------- next part --------------
      An HTML attachment was scrubbed...
      URL:
      <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110101/e
      0c1e09c/attachment-0001.htm>

      ------------------------------

      _______________________________________________
      theme-reviewers mailing list
      theme-reviewers at lists.wordpress.org
      http://lists.wordpress.org/mailman/listinfo/theme-reviewers

--------------------------------------------------------------------------

      _______________________________________________
      theme-reviewers mailing list
      theme-reviewers at lists.wordpress.org
      http://lists.wordpress.org/mailman/listinfo/theme-reviewers

----------------------------------------------------------------------------

    _______________________________________________
    theme-reviewers mailing list
    theme-reviewers at lists.wordpress.org
    http://lists.wordpress.org/mailman/listinfo/theme-reviewers

------------------------------------------------------------------------------

  _______________________________________________
  theme-reviewers mailing list
  theme-reviewers at lists.wordpress.org
  http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110101/1ac40f29/attachment-0001.htm>