[theme-reviewers] @Otto: Theme Uploader False-Positive

Chip Bennett chip at chipbennett.net
Wed Feb 23 17:36:56 UTC 2011


Strangely, I didn't get the error in Theme-Check, but only in the uploader
script.

I'll update Theme Check to trunk, and report back.

Chip

On Wed, Feb 23, 2011 at 11:17 AM, Simon Prosser <pross at pross.org.uk> wrote:

> On 02/23/11 16:56, Chip Bennett wrote:
> > I noticed a false-positive in the Theme Uploader script:
> >
> > Results of Automated Theme Scanning: Fail
> >
> >    - WARNING: Found *eval* in the PHP files. This is not allowed.
> >
> >
> > I don't use eval() anywhere in Oenology. I do, however, use the term
> > "evaluate"/"evaluated" in PHP comments. I could find no other examples of
> > "eval" appearing anywhere in any of the Theme template files.
> Looks like the eval() regex needs updating, Chip can you update
> themecheck to latest trunk and test your theme again? ive updated the
> regex.
> FYI it is now /(?<![_|a-z0-9])eval\s?\(/
>
> --
> My Blog: http://www.pross.org.uk/
> Plugins: http://www.pross.org.uk/plugins/
> Themes : http://wordpress.org/extend/themes/profile/pross
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110223/3c60e08d/attachment.htm>


More information about the theme-reviewers mailing list