[theme-reviewers] @Otto: Theme Uploader False-Positive

Simon Prosser pross at pross.org.uk
Wed Feb 23 17:17:35 UTC 2011


On 02/23/11 16:56, Chip Bennett wrote:
> I noticed a false-positive in the Theme Uploader script:
> 
> Results of Automated Theme Scanning: Fail
> 
>    - WARNING: Found *eval* in the PHP files. This is not allowed.
> 
> 
> I don't use eval() anywhere in Oenology. I do, however, use the term
> "evaluate"/"evaluated" in PHP comments. I could find no other examples of
> "eval" appearing anywhere in any of the Theme template files.
Looks like the eval() regex needs updating, Chip can you update
themecheck to latest trunk and test your theme again? ive updated the regex.
FYI it is now /(?<![_|a-z0-9])eval\s?\(/

-- 
My Blog: http://www.pross.org.uk/
Plugins: http://www.pross.org.uk/plugins/
Themes : http://wordpress.org/extend/themes/profile/pross


More information about the theme-reviewers mailing list