[theme-reviewers] Another ticket

Emil Uzelac emil at themeid.com
Tue Apr 19 23:03:33 UTC 2011


Tested in IE6, IE7, IE8, IE9 and could not replicate the message.

You are talking about:

 <script type="text/javascript">
> var $buoop = {}
> $buoop.ol = window.onload;
>  window.onload=function(){
>  if ($buoop.ol) $buoop.ol();
>  var e = document.createElement("script");
>  e.setAttribute("type", "text/javascript");
>  e.setAttribute("src", "http://browser-update.org/update.js");
>  document.body.appendChild(e);
> }
> </script>


If this is for < IE7 nothing to worry about as IE6 is gone anyways.

Emil
*----*
*Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
emil at themeid.com | http://themeid.com
Make everything as simple as possible, but not simpler. - Albert Einstein



On Tue, Apr 19, 2011 at 5:44 PM, Curtis McHale <curtis at curtismchale.ca>wrote:

> The theme I'm reviewing has JS that detects the browser version and tells
> them to update (http://browser-update.org/). There is not a theme option
> to remove this function or information in the description.
>
> What is the theme review stance on this feature?
>
> There are also some list styles missing in comments. I don't think this is
> a reason for failure but should be noted and requested for update on the
> next version. Is that correct?
>
> The theme options are strictly a page that suggests the user donate if they
> like the theme. I know that credit links are okay but I'm not sure about
> this instance.
>
> The theme calls loop-archive.php through get_template_part but the file
> doesn't actually exist. Fortunately it defaults to loop.php but I'm
> wondering how this would be addressed. The theme works but I would think
> this should be corrected in the next version either by just using loop.php
> or by adding the file that is being called. Is that correct?
>
> The theme doesn't support post_formats. I thought that they were supposed
> to at least declare it and support whichever they picked. I don't see this
> information on the Theme Review page so is this assumption incorrect?
>
> Curtis McHale
> PH: 604.751.3482
> http://www.curtismchale.ca
> Linkedin: http://www.linkedin.com/in/curtismchale
> Twitter: twitter.com/curtismchale
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110419/fbb72021/attachment.htm>


More information about the theme-reviewers mailing list