[theme-reviewers] Theme Request
Edward Caissie
edward.caissie at gmail.com
Tue Apr 19 12:42:31 UTC 2011
@rex - Please note these items on the ticket for the Theme author to be
aware of ...
... every Theme has room to improvement, even the ones we see as "approved".
These would be good recommendations to add to your review comments.
Cais.
On Tue, Apr 19, 2011 at 12:30 AM, rex posadas <rexposadas at yahoo.com> wrote:
> Thank you.
>
> I am done with my review and set the recommendation to "approve".
>
> The two items listed below were the only ones that were questionable.
> Please let me know if I missed something.
>
> Thanks again,
>
> Rex
>
> ------------------------------
> *From:* Chip Bennett <chip at chipbennett.net>
>
> *To:* theme-reviewers at lists.wordpress.org
> *Sent:* Mon, April 18, 2011 8:07:42 PM
>
> *Subject:* Re: [theme-reviewers] Theme Request
>
> I would note #1 as something to be fixed in the next revision. Use of
> "license.txt" explicitly is for (hopefully) some future
> integration/automation with Extend, and to try to create a de facto naming
> convention - but the primary intent is that the full-text license is
> declared. So, I wouldn't fail a review due to the naming inconsistency.
>
> For #2: note it in the review, but this also isn't (alone) cause to fail a
> review.
>
> Chip
>
> On Mon, Apr 18, 2011 at 10:01 PM, rex posadas <rexposadas at yahoo.com>wrote:
>
>> To All.
>>
>> Questions about the theme I am reviewing:
>>
>> 1) Is this a strict rule? The theme I am reviewing has "GPL.txt" instead
>> of "license.txt". Is it a cause for disapproval?
>>
>> Themes are *required* to declare their license explicitly, using one of
>> the following methods:
>>
>> - Adding *License* and *License URI* header slugs to style.css
>> - Including a *license.txt* file with the Theme
>>
>> 2) A css line does not fare well with the validators, but does not harm
>> the layout. is it a cause for disapproval? The css line is:
>>
>> border-radius: none;
>>
>> validators note "none" as an invalid value for that property.
>>
>> Thanks.
>>
>> Rex
>> *
>> *
>> *
>> *
>>
>> ------------------------------
>> *From:* Edward Caissie <edward.caissie at gmail.com>
>> *To:* theme-reviewers at lists.wordpress.org
>> *Sent:* Sat, April 16, 2011 4:42:46 PM
>> *Subject:* Re: [theme-reviewers] Theme Request
>>
>> @rxn: Give this one a try http://themes.trac.wordpress.org/ticket/3367
>>
>>
>> Cais.
>>
>> On Fri, Apr 15, 2011 at 1:24 PM, rex posadas <rexposadas at yahoo.com>wrote:
>>
>>> I just completed the steps to join the WP theme reviewers team, and
>>> request to
>>> be assigned a theme for the review. My wordpress.org username is: rxn
>>>
>>> Thanks and have a good day.
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110419/5556b759/attachment.htm>
More information about the theme-reviewers
mailing list