@rex - Please note these items on the ticket for the Theme author to be aware of ...<br><br>... every Theme has room to improvement, even the ones we see as "approved". These would be good recommendations to add to your review comments.<br>
<br><br>Cais.<br><br><div class="gmail_quote">On Tue, Apr 19, 2011 at 12:30 AM, rex posadas <span dir="ltr"><<a href="mailto:rexposadas@yahoo.com">rexposadas@yahoo.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div style="font-family:tahoma, 'new york', times, serif;font-size:12pt"><div></div><div>Thank you. </div><div><br></div><div>I am done with my review and set the recommendation to "approve".</div>
<div><br></div><div>The two items listed below were the only ones that were questionable. Please let me know if I missed something. </div><div><br></div><div>Thanks again, </div><div><br></div><div>Rex</div><div style="font-family:tahoma, new york, times, serif;font-size:12pt">
<br><div style="font-family:times new roman, new york, times, serif;font-size:12pt"><font size="2" face="Tahoma"><hr size="1"><b><span style="font-weight:bold">From:</span></b> Chip Bennett <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>><div class="im">
<br><b><span style="font-weight:bold">To:</span></b> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br></div><b><span style="font-weight:bold">Sent:</span></b> Mon, April 18, 2011 8:07:42
PM<div><div></div><div class="h5"><br><b><span style="font-weight:bold">Subject:</span></b> Re: [theme-reviewers] Theme Request<br></div></div></font><div><div></div><div class="h5"><br>
I would note #1 as something to be fixed in the next revision. Use of "license.txt" explicitly is for (hopefully) some future integration/automation with Extend, and to try to create a de facto naming convention - but the primary intent is that the full-text license is declared. So, I wouldn't fail a review due to the naming inconsistency.<div>
<br></div><div>For #2: note it in the review, but this also isn't (alone) cause to fail a review.</div><div><br></div><div>Chip<br><br><div class="gmail_quote">On Mon, Apr 18, 2011 at 10:01 PM, rex posadas <span dir="ltr"><<a rel="nofollow" href="mailto:rexposadas@yahoo.com" target="_blank">rexposadas@yahoo.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:tahoma,;font-size:12pt"><div style="color:black;font-family:tahoma,;font-size:12pt">
</div><div style="color:black;font-family:tahoma,;font-size:12pt">To All. </div><div style="color:black;font-family:tahoma,;font-size:12pt"><br></div><div style="color:black;font-family:tahoma,;font-size:12pt">
Questions about the theme I am reviewing:</div><div style="color:black;font-family:tahoma,;font-size:12pt"><br></div><div style="color:black;font-family:tahoma,;font-size:12pt">
1) Is this a strict rule? The theme I am reviewing has "GPL.txt" instead of "license.txt". Is it a cause for disapproval?</div><div style="color:black;font-family:tahoma,;font-size:12pt">
<br></div><div style="color:black;font-family:tahoma,;font-size:12pt"><span style="font-size:12px;line-height:22px">Themes are <b style="font-variant:normal;text-align:left">required</b> to declare their license explicitly, using one of the following methods:<ul style="font-variant:normal;text-align:left;margin-top:0px;margin-right:0px;margin-bottom:22px;margin-left:16px;padding-top:0px;padding-right:0px;padding-bottom:0px;padding-left:0px;list-style-type:square">
<li style="font-variant:normal;text-align:left;margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;padding-top:0px;padding-right:0px;padding-bottom:0px;padding-left:0px">Adding <i style="font-variant:normal;text-align:left">License</i> and <i style="font-variant:normal;text-align:left">License URI</i> header slugs to style.css</li>
<li style="font-variant:normal;text-align:left;margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;padding-top:0px;padding-right:0px;padding-bottom:0px;padding-left:0px">Including a <i style="font-variant:normal;text-align:left">license.txt</i> file with the Theme</li>
</ul></span> 2) A css line does not fare well with the validators, but does not harm the layout. is it a cause for disapproval? The css line is:</div><div style="color:black;font-family:tahoma,;font-size:12pt">
<br></div><div><font face="tahoma, 'new york', times, serif"><span style="white-space:pre-wrap"> </span>border-radius: none;</font></div><div><font face="tahoma, 'new york', times, serif"><br></font></div>
<div><font face="tahoma, 'new york', times, serif">validators note "none" as an invalid value for that property.</font></div><div><font face="tahoma, 'new york', times, serif"><br></font></div><div>
<font face="tahoma, 'new york', times, serif">Thanks.</font></div><div><font face="tahoma, 'new york', times, serif"><br></font></div><div><font face="tahoma, 'new york', times, serif">Rex</font></div>
<div style="color:black;font-family:tahoma,;font-size:12pt"><b><br></b></div><div style="color:black;font-family:tahoma,;font-size:12pt"><b><br></b></div><div style="font-family:tahoma,;font-size:12pt;color:black">
<br><div style="font-family:times new roman, new york, times, serif;font-size:12pt"><div><font size="2" face="Tahoma"><hr size="1"><b><span style="font-weight:bold">From:</span></b> Edward Caissie <<a rel="nofollow" href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>><br>
<b><span style="font-weight:bold">To:</span></b> <a rel="nofollow" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><b><span style="font-weight:bold">Sent:</span></b> Sat, April 16, 2011 4:42:46 PM<br>
<b><span style="font-weight:bold">Subject:</span></b> Re: [theme-reviewers] Theme Request<br></font><br></div><div><div></div><div><span><span>
@rxn: Give this one a try <a href="http://themes.trac.wordpress.org/ticket/3367" target="_blank">http://themes.trac.wordpress.org/ticket/3367</a></span></span><br><br><br>Cais.<br><br><div class="gmail_quote">On Fri, Apr 15, 2011 at 1:24 PM, rex posadas <span dir="ltr"><<a rel="nofollow" href="mailto:rexposadas@yahoo.com" target="_blank">rexposadas@yahoo.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I just completed the steps to join the WP theme reviewers team, and request to<br>
be assigned a theme for the review. My <a rel="nofollow" href="http://wordpress.org" target="_blank">wordpress.org</a> username is: rxn<br>
<br>
Thanks and have a good day.<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a rel="nofollow" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><span><span>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></span></span><br>
</blockquote></div><br>
</div></div></div></div><div style="color:black;font-family:tahoma,;font-size:12pt"></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a rel="nofollow" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a rel="nofollow" href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></div></div></div><div></div>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>