[theme-reviewers] theme-reviewers Digest, Vol 11, Issue 56

Doug Stewart zamoose at gmail.com
Mon Apr 18 13:18:18 UTC 2011


Whoops, a refresh and a re-login put me through. I've appended my
review to the ticket but am unable to change the ticket to
'not-approved'.


On Mon, Apr 18, 2011 at 9:16 AM, Doug Stewart <zamoose at gmail.com> wrote:
> Cais:
> That ticket was slung my way, IIRC, and I tried to add my review but
> wasn't able -- no permissions.
>
> On Mon, Apr 18, 2011 at 9:02 AM, Edward Caissie
> <edward.caissie at gmail.com> wrote:
>> @Tammie - Here is a BP ticket: http://themes.trac.wordpress.org/ticket/3546
>>
>> The review process is slightly different for BP themes at times but thanks
>> for taking this on!
>>
>>
>> Cais.
>>
>> On Mon, Apr 18, 2011 at 6:11 AM, Tammie Lister <tlister at logicalbinary.com>
>> wrote:
>>>
>>> Hi, thought about time I poked my head up and got involved too.  My
>>> username is karmatosed on WordPress.
>>> I'll put myself forward for any BuddyPress ones but can also do WordPress
>>> ones if required.  Don't know but sounds like you've got a bit of a backlog
>>> on BuddyPress ones?  I'm a theme designer who does both BuddyPress and pure
>>> WordPress themes.
>>>
>>> Regards,
>>> Tammie Lister
>>>
>>> On Monday, 18 April 2011 at 04:35,
>>> theme-reviewers-request at lists.wordpress.org wrote:
>>>
>>> Send theme-reviewers mailing list submissions to
>>> theme-reviewers at lists.wordpress.org
>>>
>>> To subscribe or unsubscribe via the World Wide Web, visit
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> or, via email, send a message with subject or body 'help' to
>>> theme-reviewers-request at lists.wordpress.org
>>>
>>> You can reach the person managing the list at
>>> theme-reviewers-owner at lists.wordpress.org
>>>
>>> When replying, please edit your Subject line so it is more specific
>>> than "Re: Contents of theme-reviewers digest..."
>>>
>>>
>>> Today's Topics:
>>>
>>> 1. Re: Join the team (Emil Uzelac)
>>> 2. BuddyPress themes? (Doug Stewart)
>>> 3. Re: BuddyPress themes? (Emil Uzelac)
>>> 4. Please assign a theme from the Theme Review Trac Queue for
>>> username smgrundy at live.com (Shawn Grundy)
>>> 5. Where can I learn more about theme security (myazalea at hotmail.com)
>>>
>>>
>>> ----------------------------------------------------------------------
>>>
>>> Message: 1
>>> Date: Sun, 17 Apr 2011 21:04:54 -0500
>>> From: Emil Uzelac <emil at themeid.com>
>>> Subject: Re: [theme-reviewers] Join the team
>>> To: theme-reviewers at lists.wordpress.org
>>> Message-ID: <BANLkTi=N5TzbQh2C81-2pBr=7jSoF4kQHg at mail.gmail.com>
>>> Content-Type: text/plain; charset="iso-8859-1"
>>>
>>> menu is OK, widgetized menu is OK too ;)
>>> *----*
>>> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
>>> emil at themeid.com | http://themeid.com
>>> Make everything as simple as possible, but not simpler. - Albert Einstein
>>>
>>>
>>>
>>> On Sun, Apr 17, 2011 at 7:54 PM, Chip Bennett <chip at chipbennett.net>
>>> wrote:
>>>
>>> I actually disagree regarding the "Menu" Widget - maybe. :)
>>>
>>> If the Theme simply provides a Widgetized sidebar, and no "Navigation
>>> Menu"
>>> markup, then this approach is fine. However, if the Theme has what would
>>> reasonably considered to be the design intent of a Navigation Menu, then
>>> that implementation must support the core Nav Menu feature.
>>>
>>> Basically: Themes are not *required* to provide Navigation Menus, but if
>>> they *do* provide a Navigation Menu, then it must support the core
>>> functionality.
>>>
>>> Chip
>>>
>>>
>>> On Sun, Apr 17, 2011 at 7:13 PM, Emil Uzelac <emil at themeid.com> wrote:
>>>
>>> 1. The theme uses the text domain of Twenty Ten in a few spots. If I
>>> remember correctly from lurking on the list this is a reason for failure
>>> of
>>> the theme.
>>> *Yes, Twenty Ten should be changed to i.e. silverville*
>>> **
>>> 2. They use a widget for the menu and instruct the user to add the Pages
>>> widget. It seems to me that it's a much better option to use a WordPress
>>> menu which defaults to list pages. I don't believe this is an issue for a
>>> fail but probably a good suggestion as an update to the user.
>>> *This part is just fine. As long as there are options for menu and being
>>> fully functional.*
>>> **
>>> 3. The CSS fails on the background-color since it's value is set to 'none'
>>> when it should be set to 'transparent'. Would this typically be a reason
>>> for
>>> failure if all other CSS is okay?
>>> *background-color: none; is invalid and it should be transparent.
>>> Recommendation would be background: none; or background-image: none; and
>>> not
>>> many people use the last one anymore. It's shortcoded via background.*
>>> **
>>> 4. There are a number of other 'recommended' items in Theme Check but
>>> these are not a reason to fail a theme correct?
>>> *Recommended isn't required, if recommendations don't cause problems, no
>>> need to fail.
>>> *
>>> Emil
>>> **
>>> *----*
>>> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
>>> emil at themeid.com | http://themeid.com
>>> Make everything as simple as possible, but not simpler. - Albert
>>> Einstein
>>>
>>>
>>>
>>> On Sun, Apr 17, 2011 at 7:01 PM, Curtis McHale
>>> <curtis at curtismchale.ca>wrote:
>>>
>>> I have a few questions about my first theme review.
>>>
>>> 1. The theme uses the text domain of Twenty Ten in a few spots. If I
>>> remember correctly from lurking on the list this is a reason for failure
>>> of
>>> the theme.
>>> 2. They use a widget for the menu and instruct the user to add the Pages
>>> widget. It seems to me that it's a much better option to use a WordPress
>>> menu which defaults to list pages. I don't believe this is an issue for a
>>> fail but probably a good suggestion as an update to the user.
>>> 3. The CSS fails on the background-color since it's value is set to
>>> 'none' when it should be set to 'transparent'. Would this typically be a
>>> reason for failure if all other CSS is okay?
>>> 4. There are a number of other 'recommended' items in Theme Check but
>>> these are not a reason to fail a theme correct?
>>>
>>> I could probably go further in to the theme but I wanted to double check
>>> on the text domain item before I did.
>>>
>>> Curtis McHale
>>> PH: 604.751.3482
>>> http://www.curtismchale.ca
>>> Linkedin: http://www.linkedin.com/in/curtismchale
>>> Twitter: twitter.com/curtismchale
>>>
>>>
>>>
>>> On Sat, Apr 16, 2011 at 4:39 PM, Edward Caissie <
>>> edward.caissie at gmail.com> wrote:
>>>
>>> Here ya go: http://themes.trac.wordpress.org/ticket/3320
>>> This will get you started ...
>>>
>>>
>>> Cais.
>>>
>>> On Sat, Apr 16, 2011 at 7:15 PM, Curtis McHale
>>> <curtis at curtismchale.ca>wrote:
>>>
>>> Figured I'd finally get off my butt and join the team after looking at
>>> the list for a few months. My trac name is curtismchale
>>>
>>> Curtis McHale
>>> PH: 604.751.3482
>>> http://www.curtismchale.ca
>>> Linkedin: http://www.linkedin.com/in/curtismchale
>>> Twitter: twitter.com/curtismchale
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>> -------------- next part --------------
>>> An HTML attachment was scrubbed...
>>> URL:
>>> <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110417/2bfcde18/attachment-0001.htm>
>>>
>>> ------------------------------
>>>
>>> Message: 2
>>> Date: Sun, 17 Apr 2011 23:17:51 -0400
>>> From: Doug Stewart <zamoose at gmail.com>
>>> Subject: [theme-reviewers] BuddyPress themes?
>>> To: theme-reviewers at lists.wordpress.org
>>> Message-ID: <BANLkTinFHy-X_z-MT4PUnfDQQ8js95o9fQ at mail.gmail.com>
>>> Content-Type: text/plain; charset=ISO-8859-1
>>>
>>> Just how far behind is the BP review queue? I've been doing some BP
>>> work and might be able to take a look.
>>>
>>> Username is ZaMoose.
>>>
>>> --
>>> -Doug
>>>
>>>
>>> ------------------------------
>>>
>>> Message: 3
>>> Date: Sun, 17 Apr 2011 22:21:58 -0500
>>> From: Emil Uzelac <emil at themeid.com>
>>> Subject: Re: [theme-reviewers] BuddyPress themes?
>>> To: theme-reviewers at lists.wordpress.org
>>> Message-ID: <BANLkTik3+SrXTKZPqPw48A7iec6=g-_05w at mail.gmail.com>
>>> Content-Type: text/plain; charset="iso-8859-1"
>>>
>>> one in queue and thanks http://themes.trac.wordpress.org/ticket/3515
>>> *----*
>>> *Emil Uzelac* | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E:
>>> emil at themeid.com | http://themeid.com
>>> Make everything as simple as possible, but not simpler. - Albert Einstein
>>>
>>>
>>>
>>> On Sun, Apr 17, 2011 at 10:17 PM, Doug Stewart <zamoose at gmail.com> wrote:
>>>
>>> Just how far behind is the BP review queue? I've been doing some BP
>>> work and might be able to take a look.
>>>
>>> Username is ZaMoose.
>>>
>>> --
>>> -Doug
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>> -------------- next part --------------
>>> An HTML attachment was scrubbed...
>>> URL:
>>> <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110417/ad26ab56/attachment-0001.htm>
>>>
>>> ------------------------------
>>>
>>> Message: 4
>>> Date: Sun, 17 Apr 2011 20:26:43 -0700
>>> From: Shawn Grundy <smgrundy at live.com>
>>> Subject: [theme-reviewers] Please assign a theme from the Theme Review
>>> Trac Queue for username smgrundy at live.com
>>> To: <theme-reviewers at lists.wordpress.org>
>>> Message-ID: <COL102-W52B1D6E3D4B364C1BE079AE910 at phx.gbl>
>>> Content-Type: text/plain; charset="iso-8859-1"
>>>
>>>
>>> Please assign a theme from the Theme Review Trac Queue for username
>>> smgrundy at live.com
>>> -------------- next part --------------
>>> An HTML attachment was scrubbed...
>>> URL:
>>> <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110417/0a9a1abf/attachment-0001.htm>
>>>
>>> ------------------------------
>>>
>>> Message: 5
>>> Date: Mon, 18 Apr 2011 05:34:21 +0200
>>> From: myazalea at hotmail.com <myazalea at hotmail.com>
>>> Subject: [theme-reviewers] Where can I learn more about theme security
>>> To: theme-reviewers at lists.wordpress.org
>>> Message-ID: <BLU0-SMTP68A5A194041773133A3E93C9910 at phx.gbl>
>>> Content-Type: text/plain; charset="utf-8"
>>>
>>> As the title sais.
>>> Are there any mustreads, and what sources are reliable. There isnt alot on
>>> this on Wordpress.org or i missed it.
>>>
>>> or should I just learn more php?
>>>
>>>
>>> Skickat fr?n min HTC
>>>
>>> ----- Reply message -----
>>> Fr?n: "Emil Uzelac" <emil at themeid.com>
>>> Till: <theme-reviewers at lists.wordpress.org>
>>> Rubrik: [theme-reviewers] Join the team
>>> Datum: m?n, apr 18, 2011 04:04
>>> menu is OK, widgetized menu is OK too ;)----Emil Uzelac | ThemeID | T:
>>> 224-444-0006 | Twitter: @EmilUzelac | E: emil at themeid.com |
>>> http://themeid.com
>>>
>>>
>>> Make everything as simple as possible, but not simpler. - Albert Einstein
>>>
>>>
>>>
>>> On Sun, Apr 17, 2011 at 7:54 PM, Chip Bennett <chip at chipbennett.net>
>>> wrote:
>>>
>>>
>>> I actually disagree regarding the "Menu" Widget - maybe. :)
>>> If the Theme simply provides a Widgetized sidebar, and no "Navigation
>>> Menu" markup, then this approach is fine. However, if the Theme has what
>>> would reasonably considered to be the design intent of a Navigation Menu,
>>> then that implementation must support the core Nav Menu feature.
>>>
>>>
>>>
>>> Basically: Themes are not *required* to provide Navigation Menus, but if
>>> they *do* provide a Navigation Menu, then it must support the core
>>> functionality.
>>> Chip
>>>
>>>
>>>
>>>
>>> On Sun, Apr 17, 2011 at 7:13 PM, Emil Uzelac <emil at themeid.com> wrote:
>>>
>>>
>>>
>>> 1. The theme uses the text domain of Twenty Ten in a few spots. If I
>>> remember correctly from lurking on the list this is a reason for failure of
>>> the theme.
>>>
>>>
>>>
>>>
>>> Yes, Twenty Ten should be changed to i.e. silverville?2. They use a widget
>>> for the menu and instruct the user to add the Pages widget. It seems to me
>>> that it's a much better option to use a WordPress menu which defaults to
>>> list pages. I don't believe this is an issue for a fail but probably a good
>>> suggestion as an update to the user.
>>>
>>>
>>>
>>>
>>> This part is just fine. As long as there are options for menu and being
>>> fully functional.?
>>> 3. The CSS fails on the background-color since it's value is set to 'none'
>>> when it should be set to 'transparent'. Would this typically be a reason for
>>> failure if all other CSS is okay?
>>>
>>>
>>>
>>>
>>> background-color: none; is invalid and it should be transparent.
>>> Recommendation would be background: none; or background-image: none; and not
>>> many people use the last one anymore. It's shortcoded via background.
>>>
>>>
>>>
>>>
>>> ?4. There are a number of other 'recommended' items in Theme Check but
>>> these are not a reason to fail a theme correct?
>>>
>>>
>>>
>>>
>>> Recommended isn't required, if recommendations don't cause? problems, no
>>> need to fail.
>>>
>>>
>>>
>>>
>>> Emil?----Emil Uzelac | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac |
>>> E: emil at themeid.com | http://themeid.com
>>>
>>>
>>>
>>>
>>>
>>> Make everything as simple as possible, but not simpler. - Albert Einstein
>>>
>>>
>>>
>>> On Sun, Apr 17, 2011 at 7:01 PM, Curtis McHale <curtis at curtismchale.ca>
>>> wrote:
>>>
>>>
>>>
>>>
>>>
>>> I have a few questions about my first theme review.
>>> 1. The theme uses the text domain of Twenty Ten in a few spots. If I
>>> remember correctly from lurking on the list this is a reason for failure of
>>> the theme..
>>>
>>>
>>>
>>>
>>>
>>>
>>> 2. They use a widget for the menu and instruct the user to add the Pages
>>> widget. It seems to me that it's a much better option to use a WordPress
>>> menu which defaults to list pages. I don't believe this is an issue for a
>>> fail but probably a good suggestion as an update to the user.
>>>
>>>
>>>
>>>
>>>
>>>
>>> 3. The CSS fails on the background-color since it's value is set to 'none'
>>> when it should be set to 'transparent'. Would this typically be a reason for
>>> failure if all other CSS is okay?
>>>
>>>
>>>
>>>
>>>
>>>
>>> 4. There are a number of other 'recommended' items in Theme Check but
>>> these are not a reason to fail a theme correct?
>>> I could probably go further in to the theme but I wanted to double check
>>> on the text domain item before I did.
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> Curtis McHale
>>> PH: 604.751.3482
>>> http://www.curtismchale.ca
>>> Linkedin: http://www.linkedin.com/in/curtismchale
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> Twitter: twitter.com/curtismchale
>>>
>>>
>>>
>>>
>>> On Sat, Apr 16, 2011 at 4:39 PM, Edward Caissie <edward.caissie at gmail.com>
>>> wrote:
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> Here ya go: http://themes.trac.wordpress.org/ticket/3320
>>> This will get you started ...
>>>
>>>
>>> Cais.
>>>
>>> On Sat, Apr 16, 2011 at 7:15 PM, Curtis McHale <curtis at curtismchale.ca>
>>> wrote:
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> Figured I'd finally get off my butt and join the team after looking at the
>>> list for a few months. My trac name is curtismchale
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> Curtis McHale
>>> PH: 604.751.3482
>>> http://www.curtismchale.ca
>>>
>>>
>>> Linkedin: http://www.linkedin.com/in/curtismchale
>>> Twitter: twitter.com/curtismchale
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>>
>>> theme-reviewers mailing list
>>>
>>> theme-reviewers at lists.wordpress.org
>>>
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>>
>>> theme-reviewers mailing list
>>>
>>> theme-reviewers at lists.wordpress.org
>>>
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>>
>>> theme-reviewers mailing list
>>>
>>> theme-reviewers at lists.wordpress.org
>>>
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>>
>>> theme-reviewers mailing list
>>>
>>> theme-reviewers at lists.wordpress.org
>>>
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>>
>>> theme-reviewers mailing list
>>>
>>> theme-reviewers at lists.wordpress.org
>>>
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>> -------------- next part --------------
>>> An HTML attachment was scrubbed...
>>> URL:
>>> <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20110418/9da3f35c/attachment.htm>
>>>
>>> ------------------------------
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>> End of theme-reviewers Digest, Vol 11, Issue 56
>>> ***********************************************
>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
>
>
> --
> -Doug
>



-- 
-Doug


More information about the theme-reviewers mailing list