[theme-reviewers] What is wrong with you people?YourejectedTarski?

[Philip M. Hofer (Frumph)]

Going to reiterate.

I am not doing theme reviews right now, several reasons.   The core team requesting we allow crap onto the repository is ridiculous.   The amount of time to spend reviewing a theme went from 15 minutes to an hour to differ between what is acceptable and what is not.  

There are deprecated functions being used that were deprecated since 2.1, if you don't fail the themes for those then why deprecate those functions to begin with?  There has to be a limit.  I'm not going to sit and look and weigh every single one, its either an all or nothing, they fail or not.  Notices that give warnings that the wrong property object signify that the code is either not receiving the right property or value which then makes the functionality of the theme just not-work.   They display as 'notices'.    If you allow that sort of thing on the repository then you're opening up a can of worms.   It just isnt productive to the wordpress users to do so.   When those themes on the repository to be looked at, exampled and used for other developers themes the never-ending cycle of crap function usage will just continue.

@Nacin chastises every little thing for the core yet when it comes to tertiary products that attach themself to WordPress he's all "Let it pass".  

When is the line going to be drawn to what is acceptable or not?  Everythings all "recommended this" "recommend that" there has to be a coding standard and it has to be 'up to date' with the current WordPress revision.
  ----- Original Message ----- 
  From: Philip M. Hofer (Frumph) 
  To: theme-reviewers at lists.wordpress.org 
  Sent: Friday, September 24, 2010 2:24 AM
  Subject: Re: [theme-reviewers] What is wrong with you people?YourejectedTarski?


  So you wouldn't reject it based on the comment_form() or the get_search_form() ?  alrightey.  And this is why i'm not doing theme reviews anymore.  You're letting crap coding pass.  Which then other people will then populate their themes with crap coding.


    ----- Original Message ----- 
    From: Andrew Nacin 
    To: theme-reviewers at lists.wordpress.org 
    Sent: Friday, September 24, 2010 2:04 AM
    Subject: Re: [theme-reviewers] What is wrong with you people? YourejectedTarski?


    On Fri, Sep 24, 2010 at 4:50 AM, Philip M. Hofer (Frumph) <philip at frumph.net> wrote: 
      Furthermore let's talk about ionfish how he has functions calling hooks instead of just embedding the hook in the location used .. erm.. why?  .. yeah I would call that unneeded unnecessary coding. 


    We're rejecting quality, extremely well coded themes on narrow technical grounds. It's not even a new theme. It's a minor update to a long-time existing one that is terrifically coded and wildly popular; it's a step in the right direction. This kind of rejection goes against the primary goals of the theme reviews. I see no reason why this theme update should not be approved. Not on the basis of it being rejected initially, not on a cursory review of the codebase, and not on this email, either.


----------------------------------------------------------------------------


    _______________________________________________
    theme-reviewers mailing list
    theme-reviewers at lists.wordpress.org
    http://lists.wordpress.org/mailman/listinfo/theme-reviewers



------------------------------------------------------------------------------


  _______________________________________________
  theme-reviewers mailing list
  theme-reviewers at lists.wordpress.org
  http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100924/3a8b4837/attachment-0001.htm>