[theme-reviewers] My First Suggest-Approval *sniff*

[Chris]

Ok .. finally this was the wrong approach :)

 

Von: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] Im Auftrag von Chip
Bennett
Gesendet: Montag, 13. September 2010 00:15
An: theme-reviewers at lists.wordpress.org
Betreff: Re: [theme-reviewers] My First Suggest-Approval *sniff*

 

But why *shouldn't* it be a requirement?

 

(Seriously: I'm open to valid arguments here. None of us know all use cases
and potential issues.)

 

Here's my thinking: unless the Theme is doing something super-complicated
with user levels that can't be one-to-one replicated with user roles, they
should be using the latter. Especially if the issue is doing a
search/replace for a text string containing a number with a text string
containing a role. Also, user roles have been around for almost five years,
which should be plenty of time to replace user levels.

 

Sure, there is some concern with newly deprecated functions. But even then,
we've stated up front that we're giving at least a month grace-period from
release of the WP version in which the deprecation takes place - and
functions to be deprecated are announced *far* in advance of
version-release. Theme/Plugin devs bear the responsibility to follow WP
development, and to keep their code current with core changes.

 

I guess, what I'm saying is that I don't think "it's inconvenient" or "it's
more work than I'm used to" is an inherently valid argument against a Theme
Review guideline. (Not directed at you, but to others who have implied as
much in other arguments.)

 

Chip

On Sun, Sep 12, 2010 at 4:53 PM, Chris <chris at thematic4you.com> wrote:

Let me pick up this part ".. it all depends on the deprecated call". 

 

The Carrington Core uses a user level in its add_submenu_page() call. The
user levels were replaced in WP 2.0 and deprecated with WP 3.0 (checked this
against WP 2.9.2), but debug tells me deprecated since 2.0.

 

 In this case I would recommend to replace the user level with a role /
capability. At this time I don't see this as an requirement.

 

Chris

 

 

Von: theme-reviewers-bounces at lists.wordpress.org
[mailto:theme-reviewers-bounces at lists.wordpress.org] Im Auftrag von Andrew
Nacin
Gesendet: Sonntag, 12. September 2010 20:09
An: theme-reviewers at lists.wordpress.org
Betreff: Re: [theme-reviewers] My First Suggest-Approval *sniff*

 

.

That's not to say that theme authors shouldn't be encouraged to rectify
notices on future theme submissions, or that the tolerance level shouldn't
go down on successive submissions by that author. But it all depends on the
notice, and it all depends on the deprecated call. If notices and deprecated
calls cannot be properly evaluated for severity, then they should not be
evaluated at all.


_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100913/3d6f8777/attachment-0001.htm>