[theme-reviewers] My First Suggest-Approval *sniff*

[Andrew Nacin]

On Sun, Sep 12, 2010 at 5:53 PM, Chris <chris at thematic4you.com> wrote:
> The Carrington Core uses a user level in its add_submenu_page() call. The
user levels
> were replaced in WP 2.0 and deprecated with WP 3.0 (checked this against
WP 2.9.2),
> but debug tells me deprecated since 2.0.

They were deprecated in 2.0. We just didn't report it until 3.0 because
that's when we introduced deprecated argument reporting. There's also some
older widget functions for example that were replaced in 2.8, but we didn't
actually add them to deprecated.php until 3.0. Those functions will report
2.8.

> In this case I would recommend to replace the user level with a role /
capability. At this
> time I don’t see this as an requirement.

Yes, it is a requirement currently, as the theme cannot have any deprecated
calls.

I said that deprecated calls should be properly evaluated for severity
specifically with user levels in mind (among other things). Using user
levels is an egregious error and I would want a theme that uses them
rejected every time.

On the other hand, if the theme uses clean_url() instead of esc_url() (as
but one example), please don't reject that theme. I'm just glad they're
sanitizing their outputs.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100912/79544bc4/attachment.htm>