[theme-reviewers] Tracking Code?

[Kenneth Newman]

If it's in a commented html, then would it matter? Most people won't mind as
long as normal users don't see it.

On Tue, Sep 7, 2010 at 9:38 AM, Chip Bennett <chip at chipbennett.net> wrote:

> It still doesn't make sense, though.
>
> 1) Why would users want to insert "tracking code" content into their raw
> HTML?
>
> 2) I *highly* suspect that this bit, currently hard-coded into footer.php
> as HTML comment, is intended to be added as "tracking code" in the future:
>
> <!--
> Clean Simple White (CSW) Theme for WordPress
>  Designed by Mazznoer
> website : http://mazznoer.web.id/
> -->
>
>
> I've required all such code be removed whenever I've run across it in any
> Theme I've reviewed. If it were added as part of the options, disabled by
> default, that would be fine, of course.
>
> So, I guess I won't worry about it for now, but it will be something to
> look out for in future versions of the Theme.
>
> Chip
>
>
> On Fri, Sep 3, 2010 at 3:13 PM, Philip M. Hofer (Frumph) <
> philip at frumph.net> wrote:
>
>>  Look in footer.php at like line #4
>>
>> 1) it's using get_settings, meh
>>
>> 2) { $$value['id'] = $value['std']; } else { $$value['id'] = get_settings(
>> $value['id'] ); }
>> but the $$ is like saying explode($vars)/but for singular  being an array,
>> what it's doing is getting the option, setting it as a $variable
>>
>> now in functions.php you can see the shortname $shortname =
>> "cleansimplewhite"; and along with that: "id" =>
>> $shortname."_tracking_code",
>> Thats basically attaching that shortname with the extension, and then
>> whatever is in the type=>textarea is used with the admin options
>>
>>
>> Long story short, everythings fine ;)
>>
>> - Phil
>>
>>
>>
>>
>> ----- Original Message -----
>> *From:* Chip Bennett <chip at chipbennett.net>
>> *To:* theme-reviewers at lists.wordpress.org
>> *Sent:* Friday, September 03, 2010 1:04 PM
>> *Subject:* [theme-reviewers] Tracking Code?
>>
>> Perhaps I'm a bit gun-shy, given some of the recent tickets we've seen;
>> but I'll ask anyway.
>>
>> Can someone take a look at Ticket #924<https://themes.trac.wordpress.org/ticket/924>?
>> Particularly, take a look at functions.php and footer.php, with respect to
>> *$cleansimplewhite_tracking_code*.
>>
>> I can't see the Theme actually defining this variable, but its presence
>> has me somewhat suspicious. It doesn't exist in either version 1.0 or 1.1 of
>> the Theme in SVN. It just showed up in version 1.2. (Note: review version is
>> 1.2, but is the first Trac ticket generated for the Theme.)
>>
>> Is this being used for something legitimate that I'm not seeing, or is the
>> developer perhaps intending to deliver some future payload of some sort?
>>
>> Thanks,
>>
>> Chip
>>
>> ------------------------------
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100907/9e886ca7/attachment.htm>