If it's in a commented html, then would it matter? Most people won't mind as long as normal users don't see it.<br><br><div class="gmail_quote">On Tue, Sep 7, 2010 at 9:38 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">It still doesn't make sense, though.<div><br></div><div>1) Why would users want to insert "tracking code" content into their raw HTML?</div>
<div><br></div><div>2) I *highly* suspect that this bit, currently hard-coded into footer.php as HTML comment, is intended to be added as "tracking code" in the future:</div>
<div><br></div><blockquote style="margin: 0pt 0pt 0pt 40px; border: medium none; padding: 0px;"><div><div><!--</div><div><span style="white-space: pre-wrap;"> </span>Clean Simple White (CSW) Theme for WordPress</div>
<div><span style="white-space: pre-wrap;"> </span>Designed by Mazznoer</div><div><span style="white-space: pre-wrap;"> </span>website : <a href="http://mazznoer.web.id/" target="_blank">http://mazznoer.web.id/</a></div>
<div>--></div></div></blockquote><div><br></div><div>I've required all such code be removed whenever I've run across it in any Theme I've reviewed. If it were added as part of the options, disabled by default, that would be fine, of course.</div>
<div><br></div><div>So, I guess I won't worry about it for now, but it will be something to look out for in future versions of the Theme.</div><div><br></div><div><font color="#888888">Chip</font><div><div></div><div class="h5">
<br><br><div class="gmail_quote">On Fri, Sep 3, 2010 at 3:13 PM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div bgcolor="#ffffff">
<div><font face="Arial" size="2">Look in footer.php at like line #4 </font></div>
<div><font face="Arial" size="2"></font> </div>
<div><font face="Arial" size="2">1) it's using get_settings, meh</font></div>
<div><font face="Arial" size="2"></font> </div>
<div><font face="Arial" size="2">2) { $$value['id'] = $value['std']; } else {
$$value['id'] = get_settings( $value['id'] ); }<br></font></div>
<div><font face="Arial" size="2">but the $$ is like saying explode($vars)/but
for singular being an array, what it's doing is getting the option,
setting it as a $variable</font></div>
<div><font face="Arial" size="2"></font> </div>
<div><font face="Arial" size="2">now in functions.php you can see the shortname
$shortname = "cleansimplewhite"; and along with that: </font>"id" =>
$shortname."_tracking_code",<br></div>
<div><font face="Arial" size="2">Thats basically attaching that shortname with the
extension, and then whatever is in the type=>textarea is used with the admin
options</font></div>
<div><font face="Arial" size="2"></font> </div>
<div><font face="Arial" size="2"></font> </div>
<div><font face="Arial" size="2">Long story short, everythings fine ;)</font></div>
<div><font face="Arial" size="2"></font> </div>
<div><font face="Arial" size="2">- Phil</font></div>
<div><font face="Arial" size="2"><br> </font></div>
<div><font face="Arial" size="2"></font> </div>
<blockquote style="border-left: 2px solid rgb(0, 0, 0); padding-left: 5px; padding-right: 0px; margin-left: 5px; margin-right: 0px;"><div>
<div style="font: 10pt arial;">----- Original Message ----- </div>
<div style="font: 10pt arial; background: none repeat scroll 0% 0% rgb(228, 228, 228);"><b>From:</b>
<a title="chip@chipbennett.net" href="mailto:chip@chipbennett.net" target="_blank">Chip
Bennett</a> </div>
<div style="font: 10pt arial;"><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
</div>
<div style="font: 10pt arial;"><b>Sent:</b> Friday, September 03, 2010 1:04
PM</div>
<div style="font: 10pt arial;"><b>Subject:</b> [theme-reviewers] Tracking
Code?</div>
<div><br></div></div><div><div></div><div>Perhaps I'm a bit gun-shy, given some of the recent tickets
we've seen; but I'll ask anyway.
<div><br></div>
<div>Can someone take a look at <a href="https://themes.trac.wordpress.org/ticket/924" target="_blank">Ticket #924</a>?
Particularly, take a look at functions.php and footer.php, with respect to
<b>$cleansimplewhite_tracking_code</b>.</div>
<div><br></div>
<div>I can't see the Theme actually defining this variable, but its presence
has me somewhat suspicious. It doesn't exist in either version 1.0 or 1.1 of
the Theme in SVN. It just showed up in version 1.2. (Note: review version is
1.2, but is the first Trac ticket generated for the Theme.)</div>
<div><br></div>
<div>Is this being used for something legitimate that I'm not seeing, or is
the developer perhaps intending to deliver some future payload of some
sort?</div>
<div><br></div>
<div>Thanks,</div>
<div><br></div>
<div>Chip</div>
</div></div><p>
</p><hr><div>
<p></p>_______________________________________________<br>theme-reviewers
mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div><p></p></blockquote></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>