[theme-reviewers] Modern Green

[Chip Bennett]

Ignore this part:

Note: the Theme also fails the license requirement, due to this line in
style.css:

*If you remix, convert, translate, modify, or distribute a copy of this
theme, please keep the links/credit in the footer.*


I had two style.css documents open. That line comes from the one I'm
currently reviewing.

Chip

On Tue, Sep 7, 2010 at 8:52 AM, Chip Bennett <chip at chipbennett.net> wrote:

> More specifically:
>  1) Themes may incorporate ONE public-facing credit link
>  2) Credit link must be either Theme URI or Author URI (as defined in
> style.css)
>  3) Both Theme URI and Author URI must be accurate and relevant.
>
> Credit Links are a *critical* requirement, IMHO. I would require an
> appropriate URI be provided in all of the following locations:
>  * style.css Theme URI
>  * style.css Description
>  * footer.php credit link (and only one such link is permitted. Theme has
> 2)
>
> Note: the Theme also fails the license requirement, due to this line in
> style.css:
>
> *If you remix, convert, translate, modify, or distribute a copy of this
> theme, please keep the links/credit in the footer.*
>
>
> FYI, License and Credit Links are the first two things I check for any
> Theme. This is why, because it's (unfortunately) all too common.
>
> Further, use of text string "twentyten" as the Theme's textdomain is an
> automatic fail. Text domains must be globally unique. I would also include
> as a *strongly recommended, not required* for the Theme to replace
> "twentyten_" function prefixes with a unique prefix (preferably, the Theme
> slug), and to replace all inline-documentation references to TwentyTen
> (except as applicable).
>
> Chip
>
> On Tue, Sep 7, 2010 at 8:07 AM, Chris <chris at thematic4you.com> wrote:
>
>>  Hi Devin,
>>
>>
>>
>> I would reject that theme for the shopedia.se link. The links need to be
>> author site / theme page.
>>
>>
>>
>> Chris
>>
>>
>>
>> *Von:* theme-reviewers-bounces at lists.wordpress.org [mailto:
>> theme-reviewers-bounces at lists.wordpress.org] *Im Auftrag von *Devin Price
>> *Gesendet:* Dienstag, 7. September 2010 05:41
>> *An:* theme-reviewers at lists.wordpress.org
>> *Betreff:* [theme-reviewers] Modern Green
>>
>>
>>
>> Every theme I've reviewed so far has been an easy fail, but this one looks
>> good to go.  Can someone check my work and make sure it actually does pass
>> review: http://themes.trac.wordpress.org/ticket/943 ?  I assigned it as
>> "needs-additional-review", but it disappeared from the queue.  Also, I
>> wasn't sure about the link (http://shopedia.se/) if that actually needs
>> to go to a theme page or actual author site.  Thanks.
>>
>> Devin Price
>> WP Theming Inc. <http://www.wptheming.com>
>> Twitter: @devinsays <http://twitter.com/devinsays>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>>
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100907/955b0f54/attachment-0001.htm>