[theme-reviewers] Functions.php Worm

[Chip Bennett]

I like the implementation, but we'll have to be careful about the
assumptions.

For example: wp_footer() will NOT always be in footer.php. It can
(legitimately) be in index.php (or any hierarchical template file
(archive.php, page.php, attachment.php, 404.php, etc.).

Chip

On Wed, Oct 13, 2010 at 11:32 AM, Otto <otto at ottodestruct.com> wrote:

> Well, regardless, I do have a simple structure I've been working on to make
> the theme checker more easily expandable. It uses a simple class based
> mechanism to allow us to easily add theme checks in on-the-fly. I'll have
> something soon to demonstrate and hopefully allow people to help me write
> the checks for it.
>
> It's *very* simple at the moment though. I'll give you a quick example of a
> check I've written for it:
>
> class Footer_Check implements themecheck {
> protected $error = null;
>  function check( $php_files, $css_files, $other_files) {
> if( strpos( $php_files['footer.php'], 'wp_footer' ) === false ) {
>  $error = "The footer.php file does not have a wp_footer() call in it.
> This is required.";
> return false;
>  }
> return true;
>  }
> function getError() { return $error; }
> }
> $themechecks[] = new Footer_Check;
>
>
> That code adds the wp_footer check in and any incoming themes will then get
> run through it. Adding new checks is as simple as creating one of those and
> popping it in a new file in the right place. No limit on number of checks.
> All errors found will be returned.
>
> -Otto
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20101013/6de72ab7/attachment-0001.htm>