[theme-reviewers] [WordPress Themes] #1141: THEME: hotmagazine - 1.1

[Edward Caissie]

Bjorn -

Although it does appear you are correct with your inclusion of the
functions, there is an issue with several of the files have an extra new
line after every line in the file.

Please review your submitted compressed files for this issue and re-submit
... I also do not see where this theme has been accepted into the
repository: http://wordpress.org/extend/themes/search.php?q=hotmagazine

It appears the Quick Review results returned several false positives for
this theme the next review will obviously require being done much more
thoroughly ... and it is expected the reviewer will find enough functional
difference between this theme and the Twenty Ten Theme for it not to be
considered a child theme of Twenty Ten.

Please note, child themes are not currently being accepted into the Theme
repository, yet.


Cais.

PS: Reply copied to trac ticket:
http://themes.trac.wordpress.org/ticket/1141

On Sun, Oct 3, 2010 at 8:24 AM, Bjorn Johansen <bj at gnb.no> wrote:

> Are you sure you have used the right theme in your review?
> The theme was accepted before..
> My theme is built on TwentyTen, and the errors you have found are covered
> by the TwentyTen code.
> I Supprised if you don't find the code from TwentyTen good enogh for
> Wordpress...
> I thought TwenyTen was the best practice for theme coding..
> *I use <?php get_footer(); ?> -the same way as twentyTen
> * I have <?php the_post_thumbnail(); ?> in loop.php file
> * I use post navigation exactly the same way as TwentyTen.
>
> From your result:
>
>
>
> Results: for hotmagazine.1.1.zip
> style.css errors:Missing bypostauthor css.
> Please add .bypostauthor to style.css (Recommendation)
>
> Missing functions:body_class was not found.
> *Required*
> See: body_class Example: <?php body_class( $class ); ?>
>
> wp_footer was not found.
> *Required*
> See: wp_footer Example: <?php wp_footer(); ?>
>
> the_post_thumbnail was not found.
> *Recemmended*
> See: the_post_thumbnail Example: <?php the_post_thumbnail( $size, $attr );
> ?>
>
> comment-reply was not found.
> *Required*
> See: Migrating Plugins and Themes to 2.7/Enhanced Comment Display Example:
> <?php if ( is_singular() ) wp_enqueue_script( "comment-reply" ); ?>
>
> Post Pagination was not found.
> *Required* *previous_posts_link()/next_posts_link() may be used instead*
> See: posts_nav_link Example: <?php posts_nav_link( 'sep', 'prelabel',
> 'nextlabel' ); ?>
>
> On Sat, 02 Oct 2010 22:58:05 +0200, WordPress Themes <
> theme-reviewers at lists.wordpress.org> wrote:
>
> Results: for hotmagazine.1.1.zip
> style.css errors:Missing bypostauthor css.
> Please add .bypostauthor to style.css (Recommendation)
>
> Missing functions:body_class was not found.
> *Required*
> See: body_class Example: <?php body_class( $class ); ?>
>
> wp_footer was not found.
> *Required*
> See: wp_footer Example: <?php wp_footer(); ?>
>
> the_post_thumbnail was not found.
> *Recemmended*
> See: the_post_thumbnail Example: <?php the_post_thumbnail( $size, $attr );
> ?>
>
> comment-reply was not found.
> *Required*
> See: Migrating Plugins and Themes to 2.7/Enhanced Comment Display Example:
> <?php if ( is_singular() ) wp_enqueue_script( "comment-reply" ); ?>
>
> Post Pagination was not found.
> *Required* *previous_posts_link()/next_posts_link() may be used instead*
> See: posts_nav_link Example: <?php posts_nav_link( 'sep', 'prelabel',
> 'nextlabel' ); ?>
>
>> #1141: THEME: hotmagazine - 1.1
>>
>
>
> Regards Bjørn Johansen
>
>>
>> ---------------------+------------------------------------------------------
>>  Reporter:  webmag  |      Owner:  cais
>>      Type:  theme   |     Status:  assigned
>> Resolution:          |   Keywords:  theme-hotmagazine,
>>
>> ---------------------+------------------------------------------------------
>> Changes (by cais):
>>
>>  * owner:  christian_gnoth => cais
>>  * status:  accepted => assigned
>>
>>
>> Comment:
>>
>>  Results: for hotmagazine.1.1.zip
>>  style.css errors:Missing bypostauthor css.
>>  Please add .bypostauthor to style.css (Recommendation)
>>
>>
>>  Missing functions:body_class was not found.
>>  *Required*
>>  See: body_class Example: <?php body_class( $class ); ?>
>>
>>  wp_footer was not found.
>>  *Required*
>>  See: wp_footer Example: <?php wp_footer(); ?>
>>
>>  the_post_thumbnail was not found.
>>  *Recemmended*
>>  See: the_post_thumbnail Example: <?php the_post_thumbnail( $size, $attr
>> );
>>  ?>
>>
>>  comment-reply was not found.
>>  *Required*
>>  See: Migrating Plugins and Themes to 2.7/Enhanced Comment Display
>> Example:
>>  <?php if ( is_singular() ) wp_enqueue_script( "comment-reply" ); ?>
>>
>>  Post Pagination was not found.
>>  *Required* *previous_posts_link()/next_posts_link() may be used instead*
>>  See: posts_nav_link Example: <?php posts_nav_link( 'sep', 'prelabel',
>>  'nextlabel' ); ?>
>>
>>
>
> --
> Using Opera's revolutionary email client: http://www.opera.com/mail/
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20101003/125b7172/attachment.htm>