[theme-reviewers] Base64 Used to Encode Transparent Images?!?

[Chip Bennett]

Based on a diff-review only, if the URI-string encoding is acceptable, then
it should pass. But I just want to make sure that the other things have had
a thorough going-over from a security perspective, just in case...

Chip

On Tue, Nov 16, 2010 at 10:46 AM, Otto <otto at ottodestruct.com> wrote:

> There may be other reasons to disapprove the theme, I was only
> referring to the use of data URI's.
>
> -Otto
>
>
>
> On Tue, Nov 16, 2010 at 10:34 AM, Chip Bennett <chip at chipbennett.net>
> wrote:
> > Okay, then. Good enough for me!
> > I'll approve the ticket. But, I'd like someone with more PHP/security
> > expertise than I have to take a look at what this Theme is doing in
> admin/
> > with overwriting files and changing permissions and whatnot, just to make
> > sure there aren't any issues. I *think* everything is okay, but following
> > all of that is still a bit above my pay grade.
> > Chip
> >
> > On Tue, Nov 16, 2010 at 10:28 AM, Otto <otto at ottodestruct.com> wrote:
> >>
> >> On Tue, Nov 16, 2010 at 10:24 AM, Chip Bennett <chip at chipbennett.net>
> >> wrote:
> >> > So, essentially, the image itself is embedded in the CSS file?
> >> > I'm still uneasy about it, but that could be due to lack of
> >> > understanding.
> >> > And I still question whether it's actually necessary.
> >>
> >> Could he put the image file in a separate file and then make an http
> >> link to it there instead? Sure.
> >> Is including the data inline like this faster? Yes, it's much, much
> >> faster.
> >>
> >> For small images (these are 1x1 pixel PNG images), this is WAY faster
> >> than including the image separately URL and incurring the overhead of
> >> an extra HTTP request.
> >>
> >> Necessary? No.
> >> Understandable and faster and better and safe and actually the correct
> >> way to do it? Yes.
> >>
> >> I give this a total thumbs up and an "okay". There's nothing wrong
> >> here of any sort.
> >>
> >> -Otto
> >> _______________________________________________
> >> theme-reviewers mailing list
> >> theme-reviewers at lists.wordpress.org
> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >
> >
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >
> >
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20101116/14767f8d/attachment.htm>