[theme-reviewers] Things to Consider for Theme Upload Checker

[Sayontan Sinha]

>
> Besides, doesn't add_theme_support() pre-date automatic_feed_links()?


I think it doesn't. Specifically add_theme_support('automatic-feed-links')
was introduced with 3.0, while add_theme_support itself was included in 2.9
and automatic_feed_links definitely existed in 2.9.

I do agree that I should push users to upgrade, however given that I am a
hobbyist rather than a pro, it is easier for me to have
backwards-compatibility in place than to help users out with a full-fledged
migration. Let me see how I can handle it, though.

Sayontan.

On Wed, Nov 10, 2010 at 7:50 PM, Chip Bennett <chip at chipbennett.net> wrote:

> Besides, doesn't add_theme_support() pre-date automatic_feed_links()?
>
> Chip
>
>
> On Wed, Nov 10, 2010 at 9:27 PM, Philip M. Hofer (Frumph) <
> philip at frumph.net> wrote:
>
>>  I've said this and many other people have hinted this.
>>
>> You should be promoting the upgrade of peoples WordPress versions whenever
>> possible.
>>
>> There's really no reason not for upgrading.   You could even make a few
>> extra bucks offering an upgrade service, if you don't I am available ;)
>>
>> - Phil
>>
>>
>> ----- Original Message -----
>> *From:* Sayontan Sinha <sayontan at gmail.com>
>> *To:* theme-reviewers at lists.wordpress.org
>> *Sent:* Wednesday, November 10, 2010 7:11 PM
>> *Subject:* [theme-reviewers] Things to Consider for Theme Upload Checker
>>
>> Hi,
>> I would like to put forth a few considerations for the theme upload
>> checker before it is used as a gating criterion for theme submissions:
>>
>>    1. Use of obsolete functions - one that comes immediately to mind is
>>    "automatic_feed_links". As per the theme guidelines I have used
>>    add_theme_support('automatic-feed-links'), however I have a considerable
>>    user-base that is on older versions of WP and for that I have the older
>>    automatic_feed_links as a backup. The upload checker reports the theme as a
>>    "fail" based on this , while manual checks would reveal that the design is
>>    as per guidelines. Would it be possible to handle this kind of a check? I am
>>    guessing there would be
>>    2. I also noticed that the checker reports that I don't have a License
>>    and License URI (I have both in style.css). It should be noted, though, that
>>    I have multiple style.css files - maybe the checker is reporting on one of
>>    those. This is listed as "Recommended" rather than an error, so it is not a
>>    big deal.
>>
>> Regards,
>> Sayontan.
>>
>> --
>> Sayontan Sinha
>> http://mynethome.net | http://mynethome.net/blog
>> --
>> Beating Australia in Cricket is like killing a celebrity. The death gets
>> more coverage than the crime.
>>
>>  ------------------------------
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>


-- 
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Beating Australia in Cricket is like killing a celebrity. The death gets
more coverage than the crime.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20101110/e0997fd7/attachment.htm>