[theme-reviewers] Fwd: THEME: Rachel - 0.8 (closed theme: not-accepted)

Sat Jun 26 15:44:35 UTC 2010

On Jun 26, 2010, at 12:52 AM, Tom Lany wrote:
> I mentioned the background customization capability because we like to see the latest capabilities being implemented in new themes, and also because I could see the background as being something many people would like to change, especially where it is currently an image.
> 

Okay, I guessed as much. That’s reasonable. What the heck ;-), I will try to throw in support right now. Time to hit the Codex. Will upload a new theme tomorrow.

	—ravi

> This wouldn't likely be a blocker by any means, but it is an idea to make the theme more customizable.
> 
> Let us know when you submit another version, and we will take a look.
> 
> Tom Lany
> http://tomlany.net
> 
> On 6/25/10 11:26 PM, // ravi wrote:
>> Tom can you perhaps explain a bit why you think the background customisation is important? Is it because of the recently added support for it in WP3? I ask because I find this a grey area... Sometimes designers might have a particular look in mind and may not want to change it. I am not a pro designer though and I do this for the fun of it, so this question is more out of curiosity.
>> 
>> I will throw in a license.txt with the standard GnU boilerplate along the line of your template.
>> 
>> Regards,
>> Ravi
>> 
>> 
>> On Jun 25, 2010, at 8:54 PM, Tom Lany<mail at tomlany.net>  wrote:
>> 
>>   
>>> That (the background image) is fine for now, but it is something that should be worked on.  Regarding your other email, that is okay, but a more detailed description would be preferable.  You could put the code below into your style.css, or add a license.txt with the full license.
>>> 
>>> /*  Copyright 2009-2010  YOUR_NAME, EMAIL, ULR, ETC
>>> 
>>>    This program is free software; you can redistribute it and/or modify
>>>    it under the terms of the GNU General Public License version 2,
>>>    as published by the Free Software Foundation.
>>> 
>>>    You may NOT assume that you can use any other version of the GPL.
>>> 
>>>    This program is distributed in the hope that it will be useful,
>>>    but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>    GNU General Public License for more details.
>>> 
>>>    You should have received a copy of the GNU General Public License
>>>    along with this program; if not, write to the Free Software
>>>    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
>>> 
>>>    The license for this software can also likely be found here:
>>> http://www.gnu.org/licenses/gpl-2.0.html
>>> */
>>> 
>>> 
>>> Tom Lany
>>> http://tomlany.net
>>> 
>>> On 6/25/10 7:41 PM, // ravi wrote:
>>>     
>>>> On Jun 25, 2010, at 5:56 PM, Tom Lany wrote:
>>>> 
>>>>       
>>>>> Thanks for fixing these issues.  The theme looks a lot better.  Take a look here: http://themes.trac.wordpress.org/ticket/166
>>>>> 
>>>>> 
>>>>>         
>>>> Hello again Tom,
>>>> 
>>>> thank you for the quick turnaround. I have address most of the issues you have listed:
>>>> 
>>>> * the screenshot disappeared because I fat fingered the move of images to the images/ directory ;-).
>>>> 
>>>> * the UTF-8 declaration tag is fixed and the JS file has the CDATA encoding now.
>>>> 
>>>> * I usually add the “this version has blah-blah…” because it’s the only way to tell the user what’s new in a version *if* they are viewing the theme from within WordPress or wordpress.org. But not a biggie… I have removed it.
>>>> 
>>>> * Regarding the customisable background colour and image, that will take a bit of work. I filed a ticket at http://github.com/ahrencode/Rachel-for-WP/issue/1.
>>>> 
>>>> If you think the last is a blocking issue, please let me know. If not, I will resubmit the theme once I hear from you.
>>>> 
>>>>    —ravi
>>>> 
>>>> 
>>>> 
>>>> 
>>>>       
>>>>> Thanks!
>>>>> 
>>>>> Tom Lany
>>>>> http://tomlany.net
>>>>> 
>>>>> On 6/25/10 4:04 PM, // ravi wrote:
>>>>> 
>>>>>         
>>>>>> On Jun 22, 2010, at 11:16 PM, Tom Lany wrote:
>>>>>> 
>>>>>> 
>>>>>>           
>>>>>>> Thanks for the note.  I was the person who reviewed this theme.  If you want to leave the code for the pages file alone, that is probably fine.  I just suggested this as it is what is commonly done in most WordPress themes.
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>>             
>>>>>> Hello Tom,
>>>>>> 
>>>>>> thanks to you, then, for your detailed review notes. I have fixed (to my knowledge) all the issues identified and posted 0.9 of the theme for review (a minute ago). I did leave the code for the pages file as is, but added a check to the common code to not display date stamp for pages (as suggested in the Codex).
>>>>>> 
>>>>>> Additionally I have passed the theme XHTML and CSS through the W3C validator and cleaned it up so the only warnings/errors that remain are the -moz, -webkit shadow and border radius stuff. FYI, since my development blog is not visible outside, I used one of my external blogs (http://0sum.org/). Various other things have been fixed as well: esc_attr() for relevant PHP generated HTML attributes, IE specific CSS, use of register_sidebar_widget() was removed, a few hints for added for the collapsibility of sidebar widgets, meta tags were made single-line, capitalised stylesheet elements were made lowercase, the PHP errors/warnings noted in the Trac ticket were resolved, reference to ‘global $_POST’ was removed, an icon that was not GPL (from pixel-mixer, as you correctly noted) was replaced, 404 page title was set to standard title size.
>>>>>> 
>>>>>> I also made sure that the search widget works (please let me know if there is some use case that I am missing). I have not yet created a print style for this theme. That will be significant work, to be done right, and I will work on that shortly.
>>>>>> 
>>>>>> Regards,
>>>>>> 
>>>>>>    —ravi
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>>           
>>>>>>> Thanks for your submission!
>>>>>>> 
>>>>>>> Tom Lany
>>>>>>> http://tomlany.net
>>>>>>> 
>>>>>>> 
>>>>>>>             
>>>>>>>> ---------- Forwarded message ----------
>>>>>>>> From: // ravi<ravi at g8o.net>
>>>>>>>> Date: Tue, Jun 22, 2010 at 10:58 PM
>>>>>>>> Subject: Re: THEME: Rachel - 0.8 (closed theme: not-accepted)
>>>>>>>> To: Edward Caissie<edward.caissie at gmail.com>
>>>>>>>> 
>>>>>>>> 
>>>>>>>> Great feedback, Edward. I will work on fixing the validation etc. Regarding icons, those links were copied over from an older version and I have stripped most icons out of the theme. I will double check and update the links or replace the icons. The one place I disagree is regarding copying code from single.php. I would rather not have duplicated code.
>>>>>>>> 
>>>>>>>> Regards,  --ravi
>>>>>>>> 
>>>>>>>> 
>>>>>>>> On Jun 22, 2010, at 10:52 PM, Edward Caissie<edward.caissie at gmail.com>    wrote:
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>>>>               
>>>>>>>>> Please see the details on this ticket in Trac: http://themes.trac.wordpress.org/ticket/8
>>>>>>>>> 
>>>>>>>>> Thank you,
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> The WordPress.org Theme Team
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>>                 
>>>>>>>> 
>>>>>>>>               
>>>>>> 
>>>>>>           
>>>> 
>>>>       