[theme-reviewers] Problem uploading new version of Hybrid theme

Joseph Scott joseph at automattic.com
Tue Jun 22 21:51:40 UTC 2010


It only looks in .php files and performs basically the same grep that
I posted earlier: grep -rn "<?[^p]" *

In this case the grep does find the string in a binary file, but the
upload time check filters out all file names that don't end in .php.

On Tue, Jun 22, 2010 at 12:29 PM, Dave Jesch <davejesch at gmail.com> wrote:
> I found a short tag in the screenshot.png file. Two of them, in fact.
>
> My guess is that the automated process that looks for the short tags looks
> in every file. It should, since some programmers like to put PHP code in a
> .inc or other non-standard file. But I think certain file types can be
> safely excluded from the search, like image files, .txt and .css and maybe a
> few others.



-- 
Joseph Scott
joseph at josephscott.org
http://josephscott.org/


More information about the theme-reviewers mailing list