[theme-reviewers] Rings and Flowers 1.0 review

Sun Jun 13 20:25:21 UTC 2010

Code Quality
HTML output appears to be valid. CSS output validates as 2.1. There is  
some inline CSS that could be cleaned up.
No CSS hacks were found.
Code is well structured.
The theme uses no JavaScript so there are no errors.
There are no PHP or WordPress errors.

Header
Header includes a doctype and <?php language_attributes(); ?>.
<head profile="http://gmpg.org/xfn/11"> is present.
Content-Type meta element is above the <title>.
bloginfo() is in use for header elements.
<?php wp_head(); ?> is present.

Footer
<?php wp_footer(); ?> is present.

JavaScript
n/a

File References
File references use bloginfo().

Untrusted Data
n/a

Basic Usability
Visual hierarchy is clear.
Navigation is easy to understand (top and right).
404 page could provide more context and help (“Error 404 - Not Found”  
isn’t that useful to the user).
Search results page could provide more information for searches that  
provide no results (suggested searches, for example). Search term does  
remain in the search box, which is a helpful reminder.

Separation of Content and Presentation
There are a few instances of inline CSS hardcoded into the PHP. These  
should be incorporated into style.css.  Also, a table is used for  
layout in <div id=”header”>.

Formatting, Function, and Logic
Posts display in the correct order.
The correct number of posts displays, as per reading settings.
Sticky posts function correctly. (I did have to set the test data  
set’s sticky post to sticky manually.)
Top level pages display correctly as tabs. Pages with children display  
a submenu for the next level down on rollover.

Navigation
Front, archive, and single pages paginate and display correctly.
index.php does not use wp_link_pages().
Layout is stable with all categories listed.

Widgets
Theme is fully widgetized.
There are no custom widgets and no overrides.
Default sidebar and widgets display the same. Theme defaults to WP  
sidebar defaults without widget finagling.

Pages
<?php comments_template(); ?> is present on page.php.
Sub-pages do not affect navigation.
No timestamps appear on pages.
No custom pages.

Posts
Edit links appear correctly based on login.
Timestamps are standard; the_time() is used.
raw HTML is styled

Multiple Page Posts
These are formatted and function correctly.

More Tag
This functions as expected.

Enclosures
Links for enclosures work.

Video
Embedded video does not display (links in square brackets).

Images
Images float and overflow properly.
$content_width is not set.
Gallery functions and displays properly.
Image borders are styled to match the theme.
No image.php template, but images in gallery display as posts with  
descriptions just fine.

Categories and Tags
Links work. Display is consistent.

Comments
Comments display correctly.
Author comments appear the same as other comments.
Gravatars work.
Pages/posts with comments turned off provide no message with that  
information.
Pages/posts with comments turned off but previous comments have the  
unclear message “NO COMMENTS.”
Trackbacks work correctly.
Form displays well when both logged in and out.
Comment HTML is correct.

Bonus Points
No print styles.
No theme classes.
No language support.
Layout remains stable until text is extremely large, so probably fine  
for most users.
Contrast is sufficient (used http://vischeck.com/)
:focus is included in the stylesheet but has no properties.
Content is accessible without styles or images.
Content degrades gracefully in print.
With sidebar navigation (i.e., without the need for :hover in the top  
horizontal navigation bar), the site is accessible on a mobile device.

Unit Test
All passes except:
Category name clash fails.
Embedded video does not work (square brackets and URLs show).
Pages and posts with comments turned off any any time could use better  
labeling.
Overall:
Needs work on copy/labeling for search results, comments, and 404, as  
well as cleaning up inline CSS and table-based layout, fixing video  
embed display, and differentiating author comments. Basic  
functionality is present. Making the theme more usable and accessible  
would take minimal effort. An easy pass with a bit of work.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/mailman/private/theme-reviewers/attachments/20100613/ee7e383e/attachment-0001.htm>