[theme-reviewers] Computer-geek/1.0/

Sun Jun 13 01:05:26 UTC 2010

Development & Coding
Code Quality
The theme uses valid HTML.
-Yes
The theme uses valid CSS.
-Yes
The theme uses minimal CSS hacks.
-No Css hacks found
The theme uses well structured code.
-Yes
The theme has no JavaScript errors.
- 1 error to undefined function 'JQuery' resulting error because not using
calling JQuery in no conflict mode.  Change JQuery to $ in inline scripts or
use included WP JQuery
The theme has no PHP or WordPress errors.
- get_settings is deprecated since version 0.0! Use get_option() instead.
Header
Check for proper DOCTYPE.
-Yes
<html> tag should include language_attributes().
-Yes
Check for correct XFN profile link http://gmpg.org/xfn/11"> in opening
<head> element tag.
-Yes
The "Content-type" meta element should be above the title element.
-Yes
Are you fetching the title and description using bloginfo()?
-Yes
Is there a feed autodiscovery <link>?
-Yes
Is there a wp_head() call?
-Yes
Footer
Is there a wp_footer() call?
-Yes
JavaScript

Is JavaScript CDATA encoded?
-No
Are you using wp_enqueue_script?
-No
Untrusted Data
-n/a
Basic Usability
The theme has a clear visual hierarchy
-Yes
The navigation is easy to understand.
-No The top menu is confusing and not styled properly.

Do you have a 404 page? It it useful and helpful?
- Has 404 page but no styled (no background) no useful information, no menu.
 Consider adding a link back to the home page and a search form.
Is the search results page helpful?
- No, it only shows the post the search term was found in.  Consider using
an archive template with small excerpts containing the search term.  Also
consider highlighting the search term in results.
Does the search results page show the previous search term?
-No
Separation Between Content and Presentation
-Yes all styling is done through css
Where possible, decorative images are in CSS.
-Yes theme contains decorative images in CSS
The theme uses CSS for all presentational aspects.
-Yes
Formatting, Function, and Logic
Are posts in the right order (front page and archive pages)?
-Yes
Are the correct number of posts showing (as set in reading settings)?
-Yes, category archives.  No in monthly archives
Are sticky posts styled and functioning correctly?
-No, sticky post is 2nd post under hello world with no distinct styling
Does the theme have pages tabs in the header? If so, do they overflow or
have problems with child pages?
-Theme does not use tabs.  Child pages show when parent page is hovered
over.

Navigation
Do front, archive, and single pages paginate correctly. Do they show the
correct number of posts?
-Does not use paginate for pages, only for posts
Posts, pages, and index should include wp_link_pages().
-No
Is layout stable with all categories showing?
-Yes
Widgets
Is the theme widgetized as fully as possible?
-No.  Only 1 sidebar widget used
Does the theme require custom widgets?
-No
Do the current widgets look correct?
-Yes
Are standard widgets setup? Should they be?
-Yes
Do any standard widgets need to be overridden?
-No
Pages
Are comments enabled for pages? Make sure pages have <?php
comments_template(); ?>.
-No pages do not include the comments-template
Check to make sure sub-pages don't mess up navigation.
-n/a
Make sure pages don't show datestamps or timestamps.
-n/a
Custom Page Templates

Make sure custom page templates in publicly released themes are not prefixed
with "page-" as in, "page-snarfer.php". See The Template File Hierarchy for
more information.
-Theme does not include any custom pages
Posts
Does the page function correctly when logged in as an administrator compared
to a normal user? (Example: do "Edit post" links work).
-Yes
Are the date and time format options respected (unless it's important to the
design)?
-Yes
To output date format: the_time( get_option( 'date_format' ) )
Is everything that needs to be styled actually styled?
-Yes.  the_meta could use some better styling

 Multiple Page Posts

Page links are displayed and formatted appropriately.
-Yes
Page links work.
-Yes
The more tag
-Not used
Does the full post appear on the permalink page?
-Yes
Enclosures
Do links for enclosures work properly?
-Yes
Video
Do embedded videos look correct?
-na

Images
-All images display fine
-Gallery template is not styled and contains no background.  This needs
work!
Categories
Category links work.
-Yes
Categories are displayed OK on front page and permalink page.
-Yes
Nested categories should be handled elegantly.
-Yes
Tags
Make sure tag links work.
-Yes all tag links work and are properly displayed.
Comments
Are comments displayed correctly?
-Yes
Are blockquotes and any applicable HTML styled appropriately?
-Yes
Author comment is highlighted differently.
-No unique styling for author comments.
User avatars (gravatars) are displayed correctly.
-Yes
No comments

No comments are shown.
Comment display form is replaced with a message, "Comments Off" or similar.
-Yes
Disabled Comments

Previous comments are still visible.
-Yes
Comment display form is replaced with a message, "Comments Off" or similar,
-Yes

Comment Form
-Comment form is displayed and works propery
Screenshot
-Yes theme has proper screenshot
Optional bonus points for supporting the following items in your theme:
-No bonus items supported in theme

Reviewer comments
Based on above tests, I would give the theme a failing grade.  Most of the
functions and templates use the exact same code as the default template.
 Fix the menu issues and remove or replace the depreciated code to get a
passing grade.

[image: Chris Olbekson]
    (713) 581-4107

[image: C3MDigital.com] <http://c3mdigital.com>
[image: Facebook] <http://facebook.com/c3mdigital>[image:
LinkedIn]<http://www.linkedin.com/in/olbekson>[image:
Google] <http://www.google.com/profiles/c3mdigital>[image:
Twitter]<http://twitter.com/chris_olbekson>[image:
Flickr] <http://flickr.com/photos/chris_olbekson>[image:
Last.fm]<http://www.last.fm/user/chris_olbekson>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/mailman/private/theme-reviewers/attachments/20100612/438537c2/attachment-0001.htm>