[theme-reviewers] Introductions: Edward Caissie aka Cais

Fri Jun 11 17:36:04 UTC 2010

Excellent, thank you for going through that theme.  Couple of follow up points:

- At this point GPLv3 is fine, there's been some discussion back and
forth and for now v3 fine for the theme directory
- Part of this theme has terms that are not compatible with the GPL,
specifically the font they include (see LicenseForSansationFont.txt).
The entire theme needs to be under terms that are GPL or compatible.
Lately fonts have been an issue for themes because many fonts have
terms that are not GPL compatible.
- I'm also not entirely sure about the icons terms of use (follows
links ending up here http://webtreats.mysitemyway.com/terms-of-use/ ),
doesn't sound entirely compatible with the GPL (distribution
limitations)
- The credit link in the footer appears to be SEO'ing for 'Blog
Designer'.  I'd expect credit link text to be relevant and accurate,
in this case I'd think something like 'Diabolique Design' or
'diaboliquedesign.com' would be better.  In general credit link text
would be the name of the theme, or the site/person being linked to.
Sadly WP themes have a history of being abused for ad/promo links as
well as SEO'ing for specific terms.  Those are abuses I don't want to
see in the theme directory.

Rest of the feedback looks great.

I noticed they uploaded a new version -
http://themes.svn.wordpress.org/diabolique-spring/1.0.3 - can you see
what's been updated there, see if it changes any of these items.

I think then we can finalize the feedback and send it off to the theme author.

On Thu, Jun 10, 2010 at 7:47 PM, Edward Caissie
<edward.caissie at gmail.com> wrote:
> Thanks for the interesting theme to review.
>
> Here are my notes:
>
>> Review: Diabolique Spring v1.0.2
>> - theme released under GPLv3 ... I would suggest GPLv2 for the repository
>>
>> - photo.png -> consider as an option, gravatar perhaps?
>> - readme.txt file may be more useful with some basic information beyond
>> the link; see note about photo.png
>>
>> x - <html> tag should include language_attributes()
>> x - fetch the title and description using bloginfo()
>> x - body_class() should be used in the <body> tag
>> x - $content_width set in functions.php
>> x - post_class() should be used as part of the_Loop
>> x - tags are not displayed
>> x - comment_class() not used
>>
>> Please address the above points. Thank You.
>
> Lines with an "x" require addressing by the outline of the "Theme
> Development Checklist" the other items are suggestions.
>
> I'm sure with more practice I will get faster at finding these points.

-- 
Joseph Scott
joseph at josephscott.org
http://josephscott.org/