[theme-reviewers] THEME: Suffusion - 3.5.4

Sun Jul 4 00:09:17 UTC 2010

Simon,
Thanks for the response. While I will fix get_links to get_bookmarks (though
the remarks clearly state that deprecated APIs are okay), the information
provided about the "undefined index" notices is just wrong and there is no
way I can fix more than 90% of those.

Pick the very first one for example, which says that there is no index
called "#horizontal-outer-widgets-1 a:hover/color" in theme-definitions.php.
That is incorrect information and you really need to see the code to see how
it works. This particular index has been defined multiple times, and there
is an inheritance array defined, so if the variable is not defined in one
place it picks it from the parent etc.

Now pick the second message that talks about a missing index called "parent"
in the same file. Same concept there - there is an inheritance defined and
that segment of the loop is executed only if a particular index is missing.

Ditto for ALL messages in that dump that talk about missing indexes - they
completely miss the point about how the coding has been done. I could list
out each one of them and explain why it is not an error and how they are
encased in conditions that will only execute if all related variables are
set. Without someone actually verifying what is happening, it is very
irritating to see the entire dump of notices (most of which are not even
close to being an error) thrown at me without context. An analogous
situation would be the debugger reporting a missing function even if that
function is enclosed in a "function_exists()" check, and you asking me to
fix it. It is more a problem of the debugger getting over-zealous than of
the code being problematic - that is the point I am trying to make.

Sayontan.

On Sat, Jul 3, 2010 at 5:46 AM, Simon Prosser <pross at pross.org.uk> wrote:

> Im sorry the queue is so long, there is a very small team wading through
> this long list.
>
> I understand that the debug info is overwhelming but it isnt just variables
> not being set.
>
> for example:
>
> Notice: get_links is *deprecated* since version 2.1! Use get_bookmarks()
> instead.
>
> Notice: automatic_feed_links is *deprecated* since version 3.0! Use
> add_theme_support( 'automatic-feed-links' ) instead. (this is optional at
> this time)
>
> Most of the undefined variables are the same repeated over and over so it
> wouldnt be too hard to fix later. but the get_links has to be fixed.
>
> I understand you have previous versions approved, so do a lot of other
> themes. I spoke to Joseph about this ticket before i closed it.
>
> Please re-upload a new version and i will prioritise it. this weekend i am
> off work, and here in ireland there is no wierd holidays going on ;)
>
>
>
>
> On 3 July 2010 12:08, Sayontan Sinha <sayontan at gmail.com> wrote:
>
>> Simon,
>> I have no idea what your comments mean. They give me no indication of what
>> you are asking me to fix.
>>
>>    1. Your comment states
>>    "Please review the theme with the test data found in the Theme
>>    Development Checklist (TDC); and with *define('WP_DEBUG', true);*included in wp-config.php
>>    (NB: functions deprecated in 3.0 should be addressed but are not
>>    show-stoppers at this time.)"
>>    When I actually look at the log, ALL the points you have listed are
>>    debug "*notices*", not "*errors*" as you state, and they have no
>>    bearing on what shows up on a user's screen. Also, I hope you understand
>>    that running something with debug turned on will only present debug
>>    information at the best - not bonafide error information.
>>    2. Also, the theme has been checked against the TDC multiple times and
>>    there is nothing on that list which the theme fails.
>>    3. Coming to the individual "errors" you listed, I don't think you did
>>    a diff with the previous version. Of all the files you listed, I haven't
>>    touched most of them since the past 5-10 releases, if not more (e.g.
>>    theme-definitions.php, most of the files in the widgets folder etc). Hence
>>    if they are truly errors, none of the last several versions should have been
>>    approved.
>>    4. Also, can you please do a proper review? Your comments seem to
>>    apply to version 3.5.3, while the version I submitted is version 3.5.4. A
>>    simple check. I am being showed a line in actions.php, line 1414 which
>>    apparently has an undefined variable called "ret".
>>
>> This theme review process is getting quite absurd. I am being provided
>> comments for a version that is *already live (3.5.3) *and being told that
>> it has innumerable errors (which are really debug notices that don't impact
>> the theme), all while version 3.5.3 has had 15,000+ downloads so far that
>> seem to be going fine for the users. Wonder how it got approved, then, in
>> the first place?
>>
>> Can someone please do a proper review and not just provide me with a list
>> of debug notices? I understand that you guys have a backlog of reviews, but
>> frankly, before the theme review experiment started (
>> http://wordpress.org/development/2010/06/expanding-the-theme-review-experiment/)
>> reviews always seemed a much more streamlined and enjoyable process. The
>> feedback I received from Joseph was timely, more precise and to the point,
>> and always helped improve the theme, quite unlike the interminable delays
>> and incomplete feedback that I am seeing now.
>>
>> Sayontan.
>>
>>
>> On Fri, Jul 2, 2010 at 9:06 PM, Simon Prosser <pross at pross.org.uk> wrote:
>>
>>> Feedback posted at http://themes.trac.wordpress.org/ticket/49
>>>
>>> --
>>> My Blog: http://www.pross.org.uk/
>>> Plugins : http://www.pross.org.uk/plugins/
>>> Themes: http://wordpress.org/extend/themes/profile/pross
>>>
>>
>>
>>
>> --
>> Sayontan Sinha
>> http://mynethome.net | http://mynethome.net/blog
>> --
>> Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native
>> American name for Lake Webster, Webster, Massachusetts, meaning "You fish on
>> your side; I fish on my side; nobody fish in the middle."
>>
>
>
>
> --
> My Blog: http://www.pross.org.uk/
> Plugins : http://www.pross.org.uk/plugins/
> Themes: http://wordpress.org/extend/themes/profile/pross
>

-- 
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native
American name for Lake Webster, Webster, Massachusetts, meaning "You fish on
your side; I fish on my side; nobody fish in the middle."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100703/ce846570/attachment-0001.htm>