[theme-reviewers] JS/jQuery and Security Reviews

[Edward Caissie]

We seem to be coming across more "additional review required" themes lately;
it can be scripting issues, security issues, or spaghetti ... all should be
addressed appropriately.

Let's continue with if a theme has an issue the reviewer is not willing to
accept, but does not feel comfortable denying then a (sepearate) comment to
that effect should be added to the end of the regular review comment(s). The
theme can be resolved "not-accepted". I read through the comments of the
ticket before I address the theme in Extend.

I will also put forward a request for a new resolution option of "needs
additional review" to help identify these themes.


Cais.

On Tue, Aug 24, 2010 at 3:26 PM, Chip Bennett <chip at chipbennett.net> wrote:

> Another Theme downloaded, only to fail one of the first things I checked...
>
> Anyway, while I move on to the next Theme, another couple questions for the
> group:
>
> 1) JavaScript/jQuery
>
> How does everyone evaluate JS (and, I suppose, jQuery) code in Themes? What
> tools do you use to find errors, and what criteria do you use?
>
> I used to write quite a bit in JS many, many years ago - though I would
> never say that I was good (or even proficient) at it. My knowledge of jQuery
> is non-existent. So, are there tools you can recommend to use, or good,
> WordPress-specific resources to study? Or, are there any reviewers who might
> want to take on a JS/jQuery guru role, to review Themes with complex use of
> such scripts?
>
> 2) Security Reviews
>
> Whatever happened to our idea of having Security gurus, who would perform
> security reviews after Themes passed the Theme Review Checklist? Is that
> still something we want to pursue? Are we to the point where Themes are
> getting turned around fast enough to justify adding an additional step in
> the workflow?
>
> (If so, Cais: can we get a "needs security review" or similar option in
> Trac to which to resolve a Theme that otherwise conforms to the Theme Review
> guidelines?)
>
> Back to the grind...
>
> Chip
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100824/1a078f6f/attachment.htm>