[theme-reviewers] Open Ticket Queue

Sun Aug 15 01:13:11 UTC 2010

What you've laid out below would be great to incorporate into the Codex.

Lance, what are your thoughts on the organization of the Codex pages related
to Theme development and review?

We really could use an explicit checklist, but I don't want to go in and
mess around too much with what you've already reorganized/cleaned up.

Chip

On Sat, Aug 14, 2010 at 7:00 PM, Philip M. Hofer (Frumph) <philip at frumph.net
> wrote:

> SETUP -
>
> Load up 3 websites in browser windows
> http://themes.trac.wordpress.org/report/1
> http://codex.wordpress.org/Theme_Review
> http://codex.wordpress.org/Theme_Unit_Test
>
> Have a window open to the themes/ directory of your review site, to get
> ready to svn the theme when reviewing
>
> Open up your wp-admin on your review site, and another one for your
> homepage of your review site
>
> View the active tickets, select the top most active ticket that is not
> assigned to someone. (status can be assigned, but just not assigned to an
> owner)
>
> Check the keywords, if it is buddypress and you cannot review buddypress
> tickets, avoid and go to the next.  Else reassign the ticket to yourself,
> right away. (You will need to be logged in);
>
> View all previous tickets on the theme, read over everything that was
> previously requested of the theme developer and all responses, check the
> revisions if necessary by searching for the theme then clicking on the
> newest revision of the theme,
> clicking the 'location' then click [view changes] at the bottom, another
> screen will appear then erasing the revision # just a character or two in
> the 'from' line so that it populates to the other revisions, select proper
> revision to compare again and click the view changes button,
> a revision history of what was changed from previous to this one will
> appear.
>
> Go back to the latest active ticket that you assigned to yourself, copy the
> link location of the SVN of it.  SVN that theme into your themes folder.
>
> clear the nacin's deprecated plugin if you have it loaded.
>
> Load up the source in a source editor software, I use Visual Studio Express
> from Microsoft on my PC, it's free and easy to use.
>
>
> -- You're now ready to review the Visual and Source of the site. --
> VISUAL CHECKS -
>
> 0) Preview the theme before activating it.  If displays the home page, move
> on.
>
> 1) During the time when you activate the theme and refresh the home page,
> verify the screenshot.png is a reasonable display of what you see on the
> home page after refreshing, if not, it's a fail.
>
> 2) Check the menubar, if it has one.  Does it look like how you arranged
> your custom menubar in appearance menus? if not go to the wp-admin ->
> appearance -> menus and see if you can assign it to the theme_unit_tests
> appropriate one.  If you are
> unable to set your own and it's not the one you have in the wp-admin ->
> appearance -> menus then fail. #see code check on wp_nav_menu();
>
> 2a) All items in your menu need to display, whether they are dropdown CSS
> or just one right after the other.
>
> 3) Do the theme_unit_test, check the page with comments disabled, checking
> if it has comments are closed/disabled/off messages, if it does, fail.
>
>
> 4) Verify that pages can have commenting on them, if not, fail.
>
> 5) Check clearing floats page, if the image in the clearing float is not
> 150px в 99px and floating properly then it's good, usually you can tell when
> floats are bad on this page is when there is text of some sort to the right
> of the image or it says edit to the right of it, as clues.
>
> 6) Make sure the layout test is the stickied post at the top of all the
> others on the home page. (if applicable), if it is, check each of the pages
> in it to make sure it navigates properly and the information inside of it is
> reasonable to accept.
>
> 7) Go down to Readability Test, on the home page it should have a valid
> MORE link as specified while the other posts do not.  It is valid if there's
> a distinction between a READMORE link that is seperate from the read the
> rest of the entry type of read more.  The posts cannot be excerpts, they
> need to be full the_content unless MORE tag is used.
>
> 8) Images test,   the top one, image alignment tests, needs to be a
> centered image, caption centered under it, surrounded by a box around it.
>
> 9) Images Test, verify alignment.  Check floats.  Check resizing.
>
> 10) Wide Image, Not Resized.  This actually means make sure that the image
> does NOT go out of the content area and bleed into other parts of the site.
> Usage of max-width and overflow are acceptable.  If it does flow over, fail
> it.
>
> 11) Check embedded video so that it displays and is viewable in the content
> area.
>
> 12) Check titles of posts to make sure they can be viewed properly and full
> title can be displayed.
>
> 13) No body posts and no-title posts must not disrupt the theme's style.
>
> 14) Go to the older entries/previous posts, there has to be links to them,
> if they are not there fail, basically your testing for paging.
>
> 15) Themes are not required to show tags and categories, but if it does
> make sure they are displaying nicely and all of them are displaying if they
> exist on the post.
>
> 16) check Protected: Test with secret password so that it clearly says its
> a protected post.  The password and submit is not required on the home page
> list, but clicking on the post and having it there is minimally required.
> Make sure that on that password protected post that you cannot see any
> comments at all.
>
> 17) On the comment test post, check the comments, make sure they're
> displaying properly.
>
> 18) On comments disabled post, make sure that it's clear that the comments
> are disabled/off on the 'single' post itself as a minimum. doesn't have to
> be on the home page, but the single page after clicking on it, it has to
> display.
>
> 19) Last post, 'many trackbacks' if the theme allows trackbacks, make sure
> they are easily read and different from regular posts, don't spend much time
> on this, this is aesthetics.
>
> 20) Check all external links on the homepage pages and singles.   Make sure
> author credits do not go to a spam site or advertising site, they need to go
> to a page or site specifically dedicated to the theme.
>
> 21) Check a 404 page and search page.
>
> NOTE: While checking all of the posts and pages and you see any notices
> warning failures or deprecated, fail.
>
> THEME OPTIONS NOTES -
>
> 1) Check theme options pages, make sure they function., i.e click save and
> no errors;
>
>
> SOURCE CHECKS -
>
> 1) View the style.css check for GPL information AND link to said GPL
> information, if it doesn't exist check for a license.txt file, if that
> doesn't exist, fail.
>
> 2) Open up header.php, verify that wp_head(); is directly above </head> and
> there are no <link rel='s to RSS feeds, ATOM is okay.  Check for .JS or .CSS
> <link rel's in the header, if there are fail, tell them to have them
> enqueued.  Note: link rel's going to stylesheet_url and pingback_url are
> allowed;  check for body_class(); if it doesn't exist in the <body> fail.
> Cursory glance the header.php to check for wp_nav_menu if thats where the
> developer put the menu, if it has wp_list_pages, wp_list_categories,
> wp_page_menu as it's menubar in a menubar style look it's a fail and they
> have to use wp_nav_menu();
>
> 3) Open up footer.php, verify that wp_footer(); is directly above </body>
> and check the links that people put in the footer sometimes verify they go
> to non-spam or adveritsing sites and to a site for the theme or author's
> theme.
>
> 4) Open up comments.php and comments-popup.php if they exist and verify
> they are using comment_form();  if not fail.
>
> SOURCE SEARCH CHECKS
>
> Most Editors will allow you to search all code in the theme for what you're
> looking for, at least visual studio express does.
>
> 1) Search for "searchform" verify that that if it's being called that its
> being done with get_search_form();
>
> 2) search for 'add_theme_support', verify that
> add_theme_support('automatic-feed-links') is present and utilized
>
> 3) search for 'register_nav'  for the wp_nav_menu, if it doesn't exist,
> search for add_theme_support('menus') if that doesn't exist, and
> wp_nav_menus is used, fail.  Note, old add_theme_support('nav-menus'); needs
> to be add_theme_support('menus'); now.
>
> 4) search for $content_width, it must set (or with an if, if already isset)
> the value of the available width of the post area.
>
> 5) search for "include" or sidebar, or the filename of a file that could be
> a sidebar that's in the theme and make sure they're loaded with
> get_sidebar(); also if includes found in non-function files but regular WP
> files it's a fail cause they need to use get_template_part();
>
> 6) cursory glance at all the custom function names in the theme, they need
> to have unique non-wordpress-core and not basic function names, a prefix
> unique to the theme or mytheme something that will make it so that it should
> not conflict.
>
> 7) search for 'dynamic_sidebar' if theme doesnt support dynamic sidebar's
> fail, if they exist search for 'register_sidebar' if that doesn't exist
> fail.
>
> 8) search for 'post_class' if that doesnt exist, fail.
>
> 9) search for 'wp_list_comments' if it has a callback then search for the
> function for it, if it doesnt exist, fail, if it does check for
> 'comment_class', if that doesnt exist with a callback then fail.
>
>
>
> WRITING THE REVIEW -
>
> 1) If any notices / warnings or deprecated were found, you are *not*
> required to display them all and you can write something to effect like:
>
> => PHP Warnings and/or wordpress errors found:
> To check for notices/warnings/fatal errors or deprecated functions, enable
> define('WP_DEBUG', true); in the wp-config.php
>
> 2) Make sure that you write references to all the things found via links
> from the http://codex.wordpress.org/Theme_Unit_Test and link to the
> http://codex.wordpress.org/Theme_Review documentation, in each entry you
> make if applicable.
>
> Example:
>
> => Clear floats not behaving properly on pages -
> http://codex.wordpress.org/Theme_Unit_Test#Clearing_Floats
>
> 3) Then after everything is itemized including any notes you want to take
> or suggestions you should add some extra info example:
>
> Developer needs to thoroughly read the
> http://codex.wordpress.org/Theme_Review  and find all the must-haves and
> update their theme(s) accordingly, this theme will continue to not pass
> until all requirements are met.
>
> Items marked with => are reasons for not being approved
> Items marked with / are just suggestions
> Items marked with - are notes
>
> This is a tertiary review, enough items didn't pass; Next reviewer might
> find more so please do everything you can to adhere to the documentation on
> what is accepted in the theme review.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100814/3f26fe15/attachment-0001.htm>