[theme-reviewers] Theme review issues

[Philip M. Hofer (Frumph)]

While the function documentation states that add_theme_support('menus') is 
not needed when registering the function, the theme review documentation 
states when using wp_nav_menu(); that it be there as a support.  Please put 
it in, regardless of the function documentation, this is being reviewed for 
proper word usage at this time and it does not adversely change your theme 
to have it as required.

$content_width is required regardless, and that function (of yours) affects 
the global variation of it. reference functions.php in twentyten for proper 
example of writing the $content_width line.

My own themes have a variation based on layout as well, so I comprimised and 
made it the minimal length, the main purpose of $content_width is mainly for 
the video output and should not really effect your theme in any way, so 
don't be concerned just add it.

- Phil


----- Original Message ----- 
From: "esmi at quirm dot net" <esmi at quirm.net>
To: <theme-reviewers at lists.wordpress.org>
Sent: Tuesday, August 10, 2010 7:55 AM
Subject: [theme-reviewers] Theme review issues


The theme review documentation at
<http://codex.wordpress.org/Theme_Review> states:

"Theme must include the following variables and functions in functions.php:

     * $content_width
<snip>
     * add_theme_support('menus’) "

The Codex page
<http://codex.wordpress.org/Function_Reference/register_nav_menu>

conversely states:
"This function automatically registers custom menu support for the theme
therefore you do not need to call add_theme_support( 'menus' );"

Yet I am having themes rejected because I am using register_nav_menu and
therefore am *not* incorporating add_theme_support('menus’).

Themes are also being rejected for failure to use $content_width in
favour of:

if ( !function_exists( 'theme_content_width' ) ) :
function theme_content_width() {
$GLOBALS['content_width'] = 900;
}
endif;

*plus* multiple CSS max-width declarations on both containers and
specific elements (eg img & object).

I'm even getting comments about spelling licence in a filename with a
'c' instead of an 's' (the former being the correct UK spelling)!

I have about 8 themes in the Directory that I'm pretty desperate to
update with bug fixes but I'm being constantly knocked back. I'm all for
standardisation and quality but come on, guys... this is getting silly.

esmi
-- 
http://quirm.net
http://blackwidows.co.uk
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers