[theme-reviewers] [WordPress Themes] Suffusion, new version 3.6.2
Philip M. Hofer (Frumph)
philip at frumph.net
Tue Aug 10 07:14:30 UTC 2010
erm 2) meant to say search template ;/ not 404
- Phil
----- Original Message -----
From: Sayontan Sinha
To: Philip M. Hofer (Frumph)
Cc: theme-reviewers at lists.wordpress.org
Sent: Monday, August 09, 2010 11:41 PM
Subject: Re: [theme-reviewers] [WordPress Themes] Suffusion,new version 3.6.2
Hello,
As per the suggestions I have resubmitted a new version of the theme: http://themes.trac.wordpress.org/ticket/656. I have addressed most points in the email thread, but please note the following:
1.. It is not possible to use wp_enqueue_style in this theme, because there is a set of styles generated from options that are included in the <head> element. The script to generate those styles (custom-styles.php) cannot be enqueued - if you try to enqueue a file it loses the WP context and cannot access theme options and other WP variables. Also, it is not possible to enqueue other CSS files and leave this without enqueuing because the CSS sheets must load in a certain sequence that gets violated if some styles are enqueued and some are not.
Also note that it is not required to enqueue a style as per the Theme Development Checklist or as per the Theme Review guidelines (only JavaScript enqueuing is required), hence this shouldn't be grounds for rejection of the theme.
2.. I was asked to register the menu locations. Again, this is not a part of the Theme Development Checklist or the Theme Review guidelines. Moreover I had already provided a fully functional way to include the WP 3.0 menus at predetermined locations. This approach essentially worked the same way as location registering, except that it let you assign more than 1 menu to a location. It was hence more flexible and the registration was not required from a functionality point of view (it was required for consistency across themes, but not for functionality). However, to avoid the incessant back-and-forth on this topic I went ahead and registered the menu locations.
3.. I could not replicate the notice on the search page. I did make some tweaks that might remove it, though.
There is a bug in the TDC - the theme uploader doesn't accept a theme if the screen shot is a JPG; the TDC says that JPG and PNG are both accepted.
Sayontan.
On Mon, Aug 9, 2010 at 11:19 AM, Philip M. Hofer (Frumph) <philip at frumph.net> wrote:
More:
=> Code Failure, see form:
----- Original Message -----
From: Philip M. Hofer (Frumph)
To: Sayontan Sinha
Cc: theme-reviewers at lists.wordpress.org
Sent: Monday, August 09, 2010 11:08 AM
Subject: Re: [theme-reviewers] [WordPress Themes] Suffusion,new version 3.6.2
Additional review information:
Btw, make sure you get these while your at it:
=> Notice: Trying to get property of non-object in \wp-content\themes\suffusion\functions\actions.php on line 1189
=> required $content_width is missing
the notice was triggered after trying to put something in the search field came up on next page
----- Original Message -----
From: Sayontan Sinha
To: Philip M. Hofer (Frumph)
Cc: theme-reviewers at lists.wordpress.org
Sent: Monday, August 09, 2010 10:41 AM
Subject: Re: [theme-reviewers] [WordPress Themes] Suffusion,new version 3.6.2
Yes, there is a reason, in the condition around these statements:
if ($suf_cdn_jquery_enabled == 'cdn' && !is_admin()) {
wp_deregister_script('jquery');
wp_register_script('jquery', 'http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js', array(), '1.0', true);
}
Different users have asked for an ability to use a CDN for JS instead of WP's files. The theme provides you with an option to switch to Google's CDN for JQuery for the same reason. It is not mandatory, if you observe carefully.
..should I continue with a more thorough review?
Sure, be my guest.
On Mon, Aug 9, 2010 at 10:33 AM, Philip M. Hofer (Frumph) <philip at frumph.net> wrote:
Additionally:
wp_deregister_script(
'jquery');
wp_register_script(
'jquery', 'http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js', array(), '1.0', true);
Is there a reason why you're doing this? the jquery library in wordpress is already 1.4.2 min.
- Phil
..should I continue with a more thorough review?
----- Original Message -----
From: Sayontan Sinha
To: Philip M. Hofer (Frumph)
Cc: theme-reviewers at lists.wordpress.org
Sent: Monday, August 09, 2010 10:23 AM
Subject: Re: [theme-reviewers] [WordPress Themes] Suffusion,new version 3.6.2
Phil,
1.. I did check the last theme that was approved - ComicPress. When activated the screenshot is very different from what you see in screenshot.png. Obviously different standards are being applied to different themes.
2.. If you search through the code, you will NOT see wp_nav_menu() being used anywhere. Only the existence of the function is being checked - the function itself is not being used. What do you want me to register?
3.. Read my email carefully. I said the review is not thorough and I didn't suggest you are testers. I understand you are in testing overdrive, but your comments come off sounding pedantic at the least.
Sayontan.
On Mon, Aug 9, 2010 at 10:10 AM, Philip M. Hofer (Frumph) <philip at frumph.net> wrote:
1) If the screenshot.png does not look like what the end user see's when activating the theme, the screenshot.png is invalid.
2) However if you USE wp_nav_menu(); then you MUST register it., you use it, register it.
3) Line 288 in actions.php is not wrapped around conditional <!-- if statements which should be used as an enqueue
4) We're not your theme testers, we're reviewers, test your theme before submitting.
- Phil
----- Original Message -----
From: Sayontan Sinha
To: theme-reviewers at lists.wordpress.org
Sent: Monday, August 09, 2010 9:54 AM
Subject: Re: [theme-reviewers] [WordPress Themes] Suffusion,new version 3.6.2
Hello,
I have been following the feedback posted for this version of the theme and I believe the review is inaccurate and not thorough. Here is what was posted:
1.. screenshot.png does not look like the theme's output.
2.. wp_nav_menu(); being used but registration of available locations not being set
3.. all scripts and styles should be enqueued ref: actions.php line 288, line 427-429 suffusion-options-page.php and various other locations, unless otherwise inapplicable to make the code work properly, i.e. <!-- IF statements
Point #1 is incorrect. You get that with the Magazine template (bundled with the theme, Templates -> Magazine in the options page) and the Minima skin (Visual Effects -> Theme Selection, WITHOUT changing any code.
Point #2: The use of wp_nav_menu() is recommended, not mandatory, as per the Theme Review checklist:
Themes are strongly suggested to support the following customization features:
a.. Custom Menu - wp_nav_menu()
a.. If a navigation menu is part of the Theme's design, it should be a customizable menu. For Themes that do not have a navigation menu, users should be able to add a Custom Menu widget.
If you define a custom WP 3.0 menu you can include it in the navigation bars from the settings in Blog Features -> Main Navigation Bar Setup or Blog Features -> Top Navigation Bar Setup. If you do not define a native WP menu you can still build your menus from the Navigation bar Setup pages in the options. I don't see how this is grounds for rejection.
Point #3: The scripts and styles are enqueued where applicable. The line #288 in actions.php that has been listed is a conditional include, and the lines 427-429 in suffusion-options-page.php are for scripts in the admin page, not in the theme itself. The stylesheets cannot be enqueued because there is a custom-styles.php file that is printed out, and enqueuing destroys the sequence for that.
IMHO, the review is not thorough enough.
Sayontan.
On Sat, Aug 7, 2010 at 10:26 AM, <theme-reviewers at lists.wordpress.org> wrote:
Thank you for uploading version 3.6.2 of Suffusion.
Feedback will be provided at http://themes.trac.wordpress.org/ticket/604
--
The WordPress.org Themes Team
theme-reviewers at lists.wordpress.org
--
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I fish on my side; nobody fish in the middle."
----------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
--
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I fish on my side; nobody fish in the middle."
--
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I fish on my side; nobody fish in the middle."
--
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I fish on my side; nobody fish in the middle."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100810/90e55e76/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 43329 bytes
Desc: not available
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20100810/90e55e76/attachment-0001.jpeg>
More information about the theme-reviewers
mailing list