<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=utf-8" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18928">
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT size=2 face=Arial>erm 2) meant to say search template ;/ not
404</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>- Phil</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="FONT: 10pt arial; BACKGROUND: #e4e4e4; font-color: black"><B>From:</B>
<A title=sayontan@gmail.com href="mailto:sayontan@gmail.com">Sayontan
Sinha</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A title=philip@frumph.net
href="mailto:philip@frumph.net">Philip M. Hofer (Frumph)</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Cc:</B> <A
title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
</DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Monday, August 09, 2010 11:41
PM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [theme-reviewers] [WordPress
Themes] Suffusion,new version 3.6.2</DIV>
<DIV><BR></DIV>Hello,<BR>As per the suggestions I have resubmitted a new
version of the theme: <A
href="http://themes.trac.wordpress.org/ticket/656">http://themes.trac.wordpress.org/ticket/656</A>.
I have addressed most points in the email thread, but please note the
following:<BR>
<OL>
<LI>It is not possible to use wp_enqueue_style in this theme, because there
is a set of styles generated from options that are included in the
<head> element. The script to generate those styles
(custom-styles.php) cannot be enqueued - if you try to enqueue a file it
loses the WP context and cannot access theme options and other WP variables.
Also, it is not possible to enqueue other CSS files and leave this without
enqueuing because the CSS sheets must load in a certain sequence that gets
violated if some styles are enqueued and some are not.<BR><B>Also note that
it is not required to enqueue a style as per the Theme Development Checklist
or as per the Theme Review guidelines (only JavaScript enqueuing is
required)</B>, hence this shouldn't be grounds for rejection of the theme.
<LI>I was asked to register the menu locations. <B>Again, this is not a part
of the Theme Development Checklist or the Theme Review guidelines</B>.
Moreover I had already provided a fully functional way to include the WP 3.0
menus at predetermined locations. This approach essentially worked the same
way as location registering, except that it let you assign <I>more than 1
menu</I> to a location. It was hence more flexible and the registration was
not required from a functionality point of view (it was required for
consistency across themes, but not for functionality). However, to avoid the
incessant back-and-forth on this topic I went ahead and registered the menu
locations.
<LI>I could not replicate the notice on the search page. I did make some
tweaks that might remove it, though.<BR></LI></OL>There is a bug in the TDC -
the theme uploader doesn't accept a theme if the screen shot is a JPG; the TDC
says that JPG and PNG are both accepted.<BR><BR>Sayontan.<BR><BR>
<DIV class=gmail_quote>On Mon, Aug 9, 2010 at 11:19 AM, Philip M. Hofer
(Frumph) <SPAN dir=ltr><<A
href="mailto:philip@frumph.net">philip@frumph.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0pt 0pt 0pt 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV bgcolor="#ffffff">
<DIV><FONT size=2 face=Arial>More:</FONT></DIV>
<DIV><FONT size=2 face=Arial>=> Code Failure, see form:</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><IMG src="cid:EBD6BEC356DD4C05A98B9907D0151AF8@frumph.net"></DIV>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(0,0,0) 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px"
dir=ltr>
<DIV class=im>
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV style="FONT: 10pt arial; BACKGROUND: rgb(228,228,228)"><B>From:</B>
<A title=philip@frumph.net href="mailto:philip@frumph.net"
target=_blank>Philip M. Hofer (Frumph)</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A title=sayontan@gmail.com
href="mailto:sayontan@gmail.com" target=_blank>Sayontan Sinha</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Cc:</B> <A
title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A> </DIV></DIV>
<DIV>
<DIV></DIV>
<DIV class=h5>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Monday, August 09, 2010 11:08
AM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [theme-reviewers]
[WordPress Themes] Suffusion,new version 3.6.2</DIV>
<DIV><BR></DIV>
<DIV><FONT size=2 face=Arial>Additional review information:</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>Btw, make sure you get these while your
at it:</FONT></DIV>
<DIV><B>=> Notice</B>: Trying to get property of non-object in
<B>\wp-content\themes\suffusion\functions\actions.php</B> on line
<B>1189</B></DIV>
<DIV><B>=> required $content_width is missing</B></DIV>
<DIV><B></B> </DIV>
<DIV><B>the notice was triggered after trying to put something in the
search field came up on next page</B></DIV>
<DIV><B></B> </DIV>
<DIV><B></B> </DIV>
<DIV>----- Original Message ----- </DIV>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(0,0,0) 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial; BACKGROUND: rgb(228,228,228)"><B>From:</B>
<A title=sayontan@gmail.com href="mailto:sayontan@gmail.com"
target=_blank>Sayontan Sinha</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A title=philip@frumph.net
href="mailto:philip@frumph.net" target=_blank>Philip M. Hofer
(Frumph)</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Cc:</B> <A
title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Monday, August 09, 2010 10:41
AM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [theme-reviewers]
[WordPress Themes] Suffusion,new version 3.6.2</DIV>
<DIV><BR></DIV>Yes, there is a reason, in the condition around these
statements:<BR> if ($suf_cdn_jquery_enabled == 'cdn'
&& !is_admin()) {<BR>
wp_deregister_script('jquery');<BR>
wp_register_script('jquery', '<A
href="http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"
target=_blank>http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js</A>',
array(), '1.0', true);<BR> }<BR><BR>Different users
have asked for an ability to use a CDN for JS instead of WP's files. The
theme provides you with an option to switch to Google's CDN for JQuery
for the same reason. It is not mandatory, if you observe
carefully.<BR><BR>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0pt 0pt 0pt 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<P><FONT size=2><FONT face=Arial>..should I continue with a more
thorough review?</FONT></FONT></P></BLOCKQUOTE>Sure, be my
guest.<BR><BR>
<DIV class=gmail_quote>On Mon, Aug 9, 2010 at 10:33 AM, Philip M. Hofer
(Frumph) <SPAN dir=ltr><<A href="mailto:philip@frumph.net"
target=_blank>philip@frumph.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0pt 0pt 0pt 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV bgcolor="#ffffff">
<DIV><FONT size=2 face=Arial>Additionally:</FONT></DIV>
<DIV><FONT size=2>
<P>wp_deregister_script(</P></FONT><FONT color=#808000 size=2><FONT
color=#808000 size=2>'jquery'</FONT></FONT><FONT size=2>);
<P>wp_register_script(</P></FONT><FONT color=#808000 size=2><FONT
color=#808000 size=2>'jquery'</FONT></FONT><FONT size=2>, </FONT><FONT
color=#808000 size=2><FONT color=#808000 size=2>'<A
href="http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"
target=_blank>http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js</A>'</FONT></FONT><FONT
size=2>, </FONT><FONT color=#0000ff size=2><FONT color=#0000ff
size=2>array</FONT></FONT><FONT size=2>(), </FONT><FONT color=#808000
size=2><FONT color=#808000 size=2>'1.0'</FONT></FONT><FONT size=2>,
</FONT><FONT color=#0000ff size=2><FONT color=#0000ff
size=2>true</FONT></FONT><FONT size=2>);</FONT>
<P><FONT size=2></FONT> </P>
<P><FONT size=2><FONT face=Arial>Is there a reason why you're doing
this? the jquery library in wordpress is already 1.4.2
min.</FONT></FONT></P>
<P><FONT size=2><FONT face=Arial>- Phil</FONT></FONT></P>
<P><FONT size=2><FONT face=Arial>..should I continue with a more
thorough review?</FONT></FONT></P></DIV>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(0,0,0) 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV>
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="FONT: 10pt arial; BACKGROUND: rgb(228,228,228)"><B>From:</B>
<A title=sayontan@gmail.com href="mailto:sayontan@gmail.com"
target=_blank>Sayontan Sinha</A> </DIV></DIV>
<DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A title=philip@frumph.net
href="mailto:philip@frumph.net" target=_blank>Philip M. Hofer
(Frumph)</A> </DIV></DIV>
<DIV>
<DIV></DIV>
<DIV>
<DIV style="FONT: 10pt arial"><B>Cc:</B> <A
title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Monday, August 09, 2010
10:23 AM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [theme-reviewers]
[WordPress Themes] Suffusion,new version 3.6.2</DIV>
<DIV><BR></DIV>Phil,<BR>
<OL>
<LI>I did check the last theme that was approved - ComicPress.
When activated the screenshot is very different from what you see
in screenshot.png. Obviously different standards are being applied
to different themes.<BR>
<LI>If you search through the code, you will NOT see wp_nav_menu()
being used anywhere. Only the existence of the function is being
checked - the function itself is not being used. What do you want
me to register?
<LI>Read my email carefully. I said the review is not thorough and
I didn't suggest you are testers. I understand you are in testing
overdrive, but your comments come off sounding pedantic at the
least.<BR></LI></OL>Sayontan.<BR><BR>
<DIV class=gmail_quote>On Mon, Aug 9, 2010 at 10:10 AM, Philip M.
Hofer (Frumph) <SPAN dir=ltr><<A href="mailto:philip@frumph.net"
target=_blank>philip@frumph.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0pt 0pt 0pt 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV bgcolor="#ffffff">
<DIV><FONT size=2 face=Arial>1) If the screenshot.png does not
look like what the end user see's when activating the theme, the
screenshot.png is invalid.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>2) However if you USE wp_nav_menu();
then you MUST register it., you use it, register it.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>3) Line 288 in actions.php is not
wrapped around conditional <!-- if statements which should be
used as an enqueue</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>4) We're not your theme testers,
we're reviewers, test your theme before submitting.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>- Phil</FONT></DIV>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(0,0,0) 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV>
<DIV></DIV>
<DIV>
<DIV style="FONT: 10pt arial">----- Original Message -----
</DIV>
<DIV
style="FONT: 10pt arial; BACKGROUND: rgb(228,228,228)"><B>From:</B>
<A title=sayontan@gmail.com href="mailto:sayontan@gmail.com"
target=_blank>Sayontan Sinha</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A
title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Monday, August 09,
2010 9:54 AM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re:
[theme-reviewers] [WordPress Themes] Suffusion,new version
3.6.2</DIV>
<DIV><BR></DIV>Hello,<BR>I have been following the feedback
posted for this version of the theme and I believe the review is
inaccurate and not thorough. Here is what was posted:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0pt 0pt 0pt 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<OL>
<LI><SPAN
style="TEXT-TRANSFORM: none; TEXT-INDENT: 0px; BORDER-COLLAPSE: separate; FONT: medium 'Times New Roman'; WHITE-SPACE: normal; LETTER-SPACING: normal; COLOR: rgb(0,0,0); WORD-SPACING: 0px"><SPAN
style="FONT-FAMILY: Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif; FONT-SIZE: 13px">
<P>screenshot.png does not look like the theme's
output.</P></SPAN></SPAN>
<LI><SPAN
style="TEXT-TRANSFORM: none; TEXT-INDENT: 0px; BORDER-COLLAPSE: separate; FONT: medium 'Times New Roman'; WHITE-SPACE: normal; LETTER-SPACING: normal; COLOR: rgb(0,0,0); WORD-SPACING: 0px"><SPAN
style="FONT-FAMILY: Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif; FONT-SIZE: 13px">
<P>wp_nav_menu(); being used but registration of available
locations not being set</P></SPAN></SPAN>
<LI><SPAN
style="TEXT-TRANSFORM: none; TEXT-INDENT: 0px; BORDER-COLLAPSE: separate; FONT: medium 'Times New Roman'; WHITE-SPACE: normal; LETTER-SPACING: normal; COLOR: rgb(0,0,0); WORD-SPACING: 0px"><SPAN
style="FONT-FAMILY: Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif; FONT-SIZE: 13px">
<P>all scripts and styles should be enqueued ref:
actions.php line 288, line 427-429
suffusion-options-page.php and various other locations,
unless otherwise inapplicable to make the code work
properly, i.e. <!-- IF
statements</P></SPAN></SPAN></LI></OL></BLOCKQUOTE>Point #1 is
incorrect. You get that with the Magazine template (bundled with
the theme, Templates -> Magazine in the options page) and the
Minima skin (Visual Effects -> Theme Selection, WITHOUT
changing any code.<BR><BR>Point #2: The use of wp_nav_menu() is
recommended, not mandatory, as per the Theme Review
checklist:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0pt 0pt 0pt 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<P>Themes are strongly suggested to support the following
customization features: </P>
<UL>
<LI>Custom Menu - <TT><A
title="Function Reference/wp nav menu"
href="http://codex.wordpress.org/Function_Reference/wp_nav_menu"
target=_blank>wp_nav_menu()</A></TT>
<UL>
<LI>If a navigation menu is part of the Theme's design, it
should be a customizable menu. For Themes that do not have
a navigation menu, users should be able to add a Custom
Menu widget. </LI></UL></LI></UL></BLOCKQUOTE>If you define a
custom WP 3.0 menu you can include it in the navigation bars
from the settings in Blog Features -> Main Navigation Bar
Setup or Blog Features -> Top Navigation Bar Setup. If you do
not define a native WP menu you can still build your menus from
the Navigation bar Setup pages in the options. I don't see how
this is grounds for rejection.<BR><BR>Point #3: The scripts and
styles are enqueued where applicable. The line #288 in
actions.php that has been listed is a conditional include, and
the lines 427-429 in suffusion-options-page.php are for scripts
in the admin page, not in the theme itself. The stylesheets
cannot be enqueued because there is a custom-styles.php file
that is printed out, and enqueuing destroys the sequence for
that.<BR><BR>IMHO, the review is not thorough
enough.<BR><BR>Sayontan.<BR><BR>
<DIV class=gmail_quote>On Sat, Aug 7, 2010 at 10:26 AM, <SPAN
dir=ltr><<A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A>></SPAN>
wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0pt 0pt 0pt 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>Thank you for uploading version 3.6.2 of
Suffusion.<BR><BR>Feedback will be provided at <A
href="http://themes.trac.wordpress.org/ticket/604"
target=_blank>http://themes.trac.wordpress.org/ticket/604</A><BR><FONT
color=#888888><BR>--<BR>The WordPress.org Themes Team<BR><A
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR></FONT></BLOCKQUOTE></DIV><BR><BR
clear=all><BR>-- <BR>Sayontan Sinha<BR><A
href="http://mynethome.net"
target=_blank>http://mynethome.net</A> | <A
href="http://mynethome.net/blog"
target=_blank>http://mynethome.net/blog</A><BR>--<BR>Lake
Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native
American name for Lake Webster, Webster, Massachusetts, meaning
"You fish on your side; I fish on my side; nobody fish in the
middle."<BR></DIV></DIV>
<P></P>
<HR>
<P></P>_______________________________________________<BR>theme-reviewers
mailing list
<DIV><BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR></DIV><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR></BLOCKQUOTE></DIV></BLOCKQUOTE></DIV><BR><BR
clear=all><BR>-- <BR>Sayontan Sinha<BR><A
href="http://mynethome.net" target=_blank>http://mynethome.net</A> |
<A href="http://mynethome.net/blog"
target=_blank>http://mynethome.net/blog</A><BR>--<BR>Lake
Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native
American name for Lake Webster, Webster, Massachusetts, meaning "You
fish on your side; I fish on my side; nobody fish in the
middle."<BR></DIV></DIV></BLOCKQUOTE></DIV></BLOCKQUOTE></DIV><BR><BR
clear=all><BR>-- <BR>Sayontan Sinha<BR><A href="http://mynethome.net"
target=_blank>http://mynethome.net</A> | <A
href="http://mynethome.net/blog"
target=_blank>http://mynethome.net/blog</A><BR>--<BR>Lake
Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native
American name for Lake Webster, Webster, Massachusetts, meaning "You
fish on your side; I fish on my side; nobody fish in the
middle."<BR></BLOCKQUOTE></DIV></DIV></BLOCKQUOTE></DIV></BLOCKQUOTE></DIV><BR><BR
clear=all><BR>-- <BR>Sayontan Sinha<BR><A
href="http://mynethome.net">http://mynethome.net</A> | <A
href="http://mynethome.net/blog">http://mynethome.net/blog</A><BR>--<BR>Lake
Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name
for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I
fish on my side; nobody fish in the middle."<BR></BLOCKQUOTE></BODY></HTML>