[buddypress-trac] [BuddyPress Trac] #8676: Database Errors for multiple notifications

[buddypress-trac]

#8676: Database Errors for multiple notifications
----------------------------------------+---------------------
 Reporter:  mike80222                   |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  10.3.0
Component:  Toolbar & Notifications     |     Version:  10.0.0
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+---------------------

Comment (by imath):

 Bingo > https://github.com/buddypress/buddypress/blob/master/src/bp-
 messages/actions/view.php#L51|L58

 So I believe a better fix is to return early from
 `bp_messages_screen_conversation_mark_notifications()` if we're viewing a
 single message. Maybe by using a more precise condition at line 228,
 something like:

 {{{
 if ( ! bp_is_my_profile() || ( bp_is_current_action( 'view' ) &&
 bp_action_variable( 0 ) ) ) {
         return;
 }
 }}}

 @oztaser could you have a look at it and if you have the same diagnostic I
 have (then we don't need unit tes), can you update the PR accordingly ?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8676#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac