[buddypress-trac] [BuddyPress Trac] #8676: Database Errors for multiple notifications

[buddypress-trac]

#8676: Database Errors for multiple notifications
----------------------------------------+---------------------
 Reporter:  mike80222                   |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  10.3.0
Component:  Toolbar & Notifications     |     Version:  10.0.0
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+---------------------

Comment (by imath):

 I've been able to reproduce. I think this case is happening because at the
 time we're trying to get all notifications, the one corresponding to the
 displayed thread has already been marked as read. So we get the one that
 is left out of the 2 notifications and this one doesn't belong to the
 thread.

 @oztaser I agree your PR is fixing the issue and we could write a unit
 test out of what I just described above.

 But I believe we need to understand why "the one corresponding to the
 displayed thread has already been marked as read" before the
 `'thread_loop_start'` is fired. Because this means we could avoid 2
 superfluous queries.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8676#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac