[buddypress-trac] [BuddyPress Trac] #8582: Add site membership requests.

[buddypress-trac]

#8582: Add site membership requests.
-------------------------------------+---------------------
 Reporter:  dcavins                  |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  10.0.0
Component:  Members                  |     Version:  9.1.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+---------------------

Comment (by dcavins):

 Replying to [comment:10 imath]:
 That's strange about the patch. It sure looks like `new file src/bp-
 members/bp-members-membership-requests.php` is included in the attached
 https://buddypress.trac.wordpress.org/attachment/ticket/8582/8582.3.diff.
 Maybe when you applied the patch, the new file wasn't created because of
 permissions or similar?

 Regarding file organization, I am in favor or moving `filters` and
 `actions` to the main file `bp-members-membership-requests.php`. Putting
 filters in a filters file is how BP is often organized, so I respected
 that, but personally prefer having files organized by content, not part of
 speech.

 I think the Approved column is useful (it's a renaming of an existing
 signup column, date activation email sent) because some pending
 memberships will have been "approved" but not activated by the end user
 yet. The column tells you at a glance when the approval occurred or if it
 hasn't yet. You could also use it to sort the "not yet approved" requests
 up to the top (I will enable sorting on it).

 The $64,000 question: What should we do with meta for the 10.0 release?
 Leave it on the "activate" and "approve" screens? Use a modal, but maybe
 move the access link to the "actions" cell? I think it would be great to
 add an inline viewer/editor, but let's not let it hold up anything--it can
 be a nice improvement later.

 Thanks!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8582#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac