[buddypress-trac] [BuddyPress Trac] #8582: Add site membership requests.

[buddypress-trac]

#8582: Add site membership requests.
-------------------------------------+---------------------
 Reporter:  dcavins                  |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  10.0.0
Component:  Members                  |     Version:  9.1.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+---------------------

Comment (by imath):

 Hi @dcavins

 I've tested the patch, and was a bit surprised at the beginning as
 submitting a membership request was sending an activation email. Then I
 understood checking your previous patch that one file was missing. So I've
 used 8582.1.diff to include the missing `bp-members-membership-
 requests.php` file into
 [https://buddypress.trac.wordpress.org/attachment/ticket/8582/8582.4.patch
 8582.4.patch] to have it work the way it should. You should probably check
 again my edits about this file 😆. 8582.4.patch also includes some
 recommandation (eg: escaping some outputs, or displaying a message when
 there are no profile field to display into the modal).

 I have some remarks/questions 😁.

 - I guess the purpose of having a separate `bp-members-membership-
 requests.php` is to only include it if Membership requests are allowed, so
 I've edited this part in the 8582.4 patch. But I see a lot of functions
 that should be moved into this file... (eg: all the ones that are inside
 `src/bp-members/bp-members-filters.php`).
 - Why do we need `bp_is_active( 'members', 'invitations' )` for site
 membership requests? It seems weird to me.
 - Is the Approved column necessary into the WP List Table? I don't see the
 benefit of it.
 - The "Manage signups" WP Admin Menu item should probably be renamed
 "Manage Pending members".

 Otherwise, thanks a lot for your great progress about the ticket, we're
 getting closer to the finish line 🏁.

 On a side note and to follow up with our latest dev-chat: I've checked how
 WordPress uses the inline-edit feature and I don't like it. I believe we
 can do things better now we have the BP REST API and modern JavaScript.
 I'll explore this in another ticket.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8582#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac