[buddypress-trac] [BuddyPress Trac] #5500: Date xprofile field enhancement

buddypress-trac noreply at wordpress.org
Wed Aug 31 12:10:19 UTC 2016

#5500: Date xprofile field enhancement
 Reporter:  sooskriszta              |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  2.7
Component:  Extended Profile         |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |

Comment (by boonebgorges):

 Thank you, @mercime! This is great feedback, and the changes look good.

 One friendly amendment. I understand the motivation behind adding
 (visible) labels to the Absolute and Relative radio buttons. But the way
 they were laid out in your patch didn't feel like it flowed to me. I took
 a swing in [attachment:5500.4.diff] at compressing the space a little bit.
 This also allowed me to do some vertical alignment, and match the "Start"
 and "End" labels a bit. Screenshots at various window widths are above.
 What do you think?

 With this new format, I feel like the word "Year" is unnecessary; the fact
 that the default values are years should be explanation enough. Does this
 seem right? If not, we can certainly add it back in. Or if you think it
 primarily needs to exist for screen readers, maybe it can be put in
 screen-reader-specific text? I'm happy to go with what you think is best -
 I just wanted to push one last time for what I think is the more
 aesthetically pleasing option :)

 @DJPaul I don't know why I went with underscores. I seem to recall briefly
 thinking about it, and seeing that this particular form had a mix, so I
 went with what seemed "cleaner" to send through `$_POST`. I don't think WP
 has an explicit style recommendation on this. If you want to go with
 hyphens (which is what I gather from your comment), I'll make the change.
 Let me wait until I merge @mercime's changes, so I don't have to deal with
 stale patches.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5500#comment:64>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list