[buddypress-trac] [BuddyPress Trac] #5500: Date xprofile field enhancement

buddypress-trac noreply at wordpress.org
Wed Aug 31 11:41:34 UTC 2016

#5500: Date xprofile field enhancement
 Reporter:  sooskriszta              |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  2.7
Component:  Extended Profile         |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |

Comment (by DJPaul):

 Nice work, @mercime! I think this is all good.

 If we go with the reworded "Start" and "End", I still think those two
 could benefit from a translator comment explaining its context.

 @boonebgorges This was in the previous commit, but I noticed for the form
 elements `name` properties, you've used underscores to separate the words
 instead of a hyphen. I know convention for CSS class names is to use a
 hyphen -- I vaguely remember @johnjamesjacoby going on a mass
 search/replace during the early years of BuddyPress -- but is it proper
 WordPress convention to use the underscore for form names?

 I don't really know what this is called so it's hard to search for, but I
 couldn't easily see any mention on the WordPress Coding Standards
 document, so figured i'd ask. Thanks!

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5500#comment:63>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list