[buddypress-trac] [BuddyPress Trac] #7226: Update BP_buttons class to accept new arg param for $element_type

buddypress-trac noreply at wordpress.org
Fri Aug 26 17:21:11 UTC 2016

#7226: Update BP_buttons class to accept new arg param for $element_type
 Reporter:  hnla         |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.7
Component:  Core         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |

Comment (by hnla):

 >FWIW, the class is called BP_Button, the function names have the word
 button in them.

 I too thought about that, still it's a bad use of words the class should
 simply have been `BP_Make_Stuff_Clickity`

 Button, and also 'tabs' cause irritation `item-list-tabs` really what's an
 item, why are they tabs don't look like tabs, list is it a list? :)

 Stay with the names r-a-y it's not worth re-factoring again.

 I've adjusted the Nouveau class and functions and tested a basic passing
 of various params to generate lists, buttons, anchors and their attrs
 which appears to be ok or at least haven't spotted issues. Backpat link_*
 atts work as I didn't update Nouveau for those. Class doesn't seem to be
 passing through as an array key/value pair of 'button_attr' but that might
 be something on my end.

 We ought to get `data-*=""` rendering if possible.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7226#comment:20>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list