[buddypress-trac] [BuddyPress Trac] #7226: Update BP_buttons class to accept new arg param for $element_type

buddypress-trac noreply at wordpress.org
Fri Aug 26 09:26:02 UTC 2016

#7226: Update BP_buttons class to accept new arg param for $element_type
 Reporter:  hnla         |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.7
Component:  Core         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |

Comment (by hnla):

 We appear amongst other nomenclature changes to have changed element to
 button, as I tried to point out button is a bad choice, button both
 defines a visual style ( which we're not concerned with) and an actual
 real world element (equally what we're only concerned with if that choice
 is set as a string) and calling 'it' a button when it might be a list item
 and styles as a simple link - but hey ho.

 I have to now go and revise the Nouveau class and functions for all the
 passed params names and recheck to see if all conditions actually work,
 have a suspicion this might throw up issues.

 @r-a-y  good catch with the img element that element didn't occur to me at
 the time.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7226#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list