[buddypress-trac] [BuddyPress Trac] #7226: Update BP_buttons class to accept new arg param for $element_type

buddypress-trac noreply at wordpress.org
Wed Aug 24 19:16:45 UTC 2016

#7226: Update BP_buttons class to accept new arg param for $element_type
 Reporter:  hnla         |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.7
Component:  Core         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |

Comment (by hnla):

 A lot of the reasoning is based on having to try and accommodate the
 changes from the viewpoint of nouveau's custom classes & functions and is
 where I test and pass through my params.

 >The patch looks for li as a specific wrapper and then you set a new
 property called li_class. If you set wrapper to li, why do you need a
 li_class when there is an existing wrapper_class?

 There is method in the madness here and lots of stress in trying to puzzle
 through this for what's frankly something that just needs to be quick and
 simple, it may seem odd I agree but those params for the li help the
 custom functions pass through a bool that allows the main class know what
 to do., badly explained but... it probably makes more sense if you saw the
 Nouveau functions but I haven't pushed those up yet.

 I'm sure you're right about a lot of this but equally some of it's a
 little trickier than it appears at first glance, and yes I can see you
 code example looks& reads better but if you change things it needs to be
 done in tandam with some custom $buttons args. because it all falls over
 all too easily :)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7226#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list