[buddypress-trac] [BuddyPress Trac] #6750: Extending Messages notification should be improved

buddypress-trac noreply at wordpress.org
Sat Nov 28 02:48:18 UTC 2015

#6750: Extending Messages notification should be improved
 Reporter:  imath                  |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  2.5
Component:  Component - Messaging  |     Version:  1.0
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch              |
Changes (by boonebgorges):

 * milestone:  Awaiting Review => 2.5


 Ugh, this was a pretty ugly one. Good catch, imath. Moving the
 `new_message` filter into the `if ( 'new_message' === $action )` block,
 and introducing a new catch-all filter, both seem good to me.

 It's a pity that these filters were originally introduced as dynamic. We
 could greatly simplify the documentation, and greatly decrease the number
 of filters, if each notification function had a single filter:
 `bp_messages_format_notification` (or whatever), which would accept an
 `$action` and `$amount` parameter in addition to whatever params they
 normally accept. This is not a criticism of [attachment:6750.patch] - it
 just copies what the rest of BP is doing. Just registering my sadness for
 the record :)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6750#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list