[buddypress-trac] [BuddyPress Trac] #6750: Extending Messages notification should be improved

[buddypress-trac]

#6750: Extending Messages notification should be improved
-----------------------------------+-----------------------------
 Reporter:  imath                  |      Owner:
     Type:  enhancement            |     Status:  new
 Priority:  normal                 |  Milestone:  Awaiting Review
Component:  Component - Messaging  |    Version:  1.0
 Severity:  normal                 |   Keywords:  has-patch
-----------------------------------+-----------------------------
 If you try to add a new notification action (meaning !== 'new_message'),
 it's quite risky:

 - First you get a notice error because in this case the $text var is not
 defined (which is not so serious)

 - Most serious is you can't be sure to only filter your custom action
 because you need to filter `bp_messages_single_new_message_notification`
 which is not in the `if ( 'new_message' === $action )` statement and which
 is not including the needed $action and $format variables.

 Maybe we should improve this. See attached patch.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6750>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac