[buddypress-trac] [BuddyPress Trac] #6418: Introduce functionality to query members by member_type where member_type NOT IN

[buddypress-trac]

#6418: Introduce functionality to query members by member_type where member_type
NOT IN
------------------------------------------+-----------------------------
 Reporter:  lakrisgubben                  |       Owner:
     Type:  enhancement                   |      Status:  new
 Priority:  normal                        |   Milestone:  Future Release
Component:  Component - Members           |     Version:  2.2.3
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |
------------------------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:  has-patch dev-feedback => needs-patch needs-unit-tests
 * milestone:  Awaiting Review => Future Release


Comment:

 This is great, lakrisgubben - thanks for the patch. A couple thoughts:

 - Gotta have unit tests for this.
 - If we're going to introduce 'member_type__not_in', we should probably
 provide 'member_type__in' as well. 'member_type' already allows for an
 array of types, but just for consistency. If someone passes both
 'member_type' and 'member_type__in', let's have 'member_type' take
 precedence.
 - Can we do this without spinning up a separate `WP_Tax_Query`? Seems like
 we should be able to assemble arguments for a single tax query object
 related to bp_member_type. This might require that the SQL regex be
 reworked a bit.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6418#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac