[buddypress-trac] [BuddyPress Trac] #5914: Registration form: Proposed enhancements for touch devices

buddypress-trac noreply at wordpress.org
Fri Jan 2 14:31:56 UTC 2015

#5914: Registration form: Proposed enhancements for touch devices
 Reporter:  standardspace             |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  2.2
Component:  Theme / Template Parts    |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |

Comment (by boonebgorges):

 Thanks for the patch, r-a-y!

 > Should we not maybe rename the function

 I agree - presumably we'd use the same function on the settings (and
 xprofile?) templates. In theory, it could also be used for things other
 than touch-screen-specific attributes (and in fact, r-a-y's patch applies
 a couple attributes even when not on mobile). How about
 `bp_settings_field_attributes()` or even `bp_form_field_attributes()`?
 Like hnla suggests, no reason to prevent this useful function from being
 used by theme authors.

 > do we we run with deprecated values or take a decisions to support
 specific versions? It's another factor I'm uncomfortable with having BP
 now making decisions to support specific devices and needing to review
 that from time to time?

 Yeah, this is a rabbit hole in general. But in this specific case, it
 seems pretty clear that we should use 'none'. iOS 5 has been obsolescent
 for a couple years.

 > we may actually need to describe 'autocapitalize' here as the default
 might take effect, we need this 'auto' behaviour disabled leaving the
 choice to capitalize in the users hands.

 If I read this correctly, you're saying that 'username' should get
 'autocapitalize=none'. I agree.

 hnla, thanks for lending your expertise here!

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5914#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list