[buddypress-trac] [BuddyPress Trac] #6572: Conversation replies don't immediately inherit the HTML of custom templates.

buddypress-trac noreply at wordpress.org
Wed Aug 5 18:54:04 UTC 2015


#6572: Conversation replies don't immediately inherit the HTML of custom
templates.
-----------------------------------+------------------
 Reporter:  CharlesMabe            |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  2.4
Component:  Component - Messaging  |     Version:  1.7
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch              |
-----------------------------------+------------------
Changes (by r-a-y):

 * keywords:  needs-patch => has-patch
 * priority:  high => normal
 * version:  2.3.2 => 1.7
 * type:  defect (bug) => enhancement
 * milestone:  Awaiting Review => 2.4


Comment:

 The problem is due to us hardcoding the markup for the AJAX message:
 https://buddypress.trac.wordpress.org/browser/tags/2.3.2/src/bp-templates
 /bp-legacy/buddypress-functions.php#L1509

 Which can be different from the `/members/single/messages/single.php`
 template.

 I think we should introduce a new template called
 `/members/single/messages/content-single.php` or something like that so we
 can share the markup in both instances.

 Please test the attached patch and you should be able to just alter
 `/members/single/messages/content-single.php` and that should apply for
 both AJAX and regular PMs.

 Note: We might rename the new template to something else like `'single-
 content.php'` later on.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6572#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list