[buddypress-trac] [BuddyPress Trac] #5298: Core notifications and emails when a blog post receives a comment

buddypress-trac noreply at wordpress.org
Mon Jan 20 21:33:36 UTC 2014

#5298: Core notifications and emails when a blog post receives a comment
 Reporter:  henrywright            |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  2.0
Component:  Core                   |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  needs-patch has-patch  |
Changes (by boonebgorges):

 * milestone:  Future Release => 2.0


 Hey henrywright - Thanks for the patch. Couple thoughts:

 - To me, it makes more sense for this to happen in the blogs component. No
 point in loading it into memory if Blogs is not activated. This'll also
 take care of the multisite bit.
 - I like the motivation behind your suggestion to combine with
 `bp_activity_new_comment_notification_helper()`, but I think that the
 logic required internally would probably be overkill. Though activity
 comments and blog comments are both called "comments", they're different
 types of data objects, and the logic for building the content of the
 activity item would have to be very different. You'd end up with great big
 `if` `then` blocks. Probably makes more sense to keep them separate.
 - I really like the bit about adding BP notifications for blog
 - Your 1-5 points above :)

 I'll tentatively put this into 2.0. Let's discuss in the upcoming weeks as
 we set scope for 2.0.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5298#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list